Closed Bug 1501048 Opened Last year Closed Last year

pushes with failed gecko decision tasks can't be saved, reruns will fail

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: aryx, Assigned: dustin)

Details

Attachments

(1 file)

bz pushed to Try and got a gecko decision task failure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96d1e5bb75080968b1042279f7718e4758aa9dbb&selectedJob=206973234

HTTPError: 400 Client Error: Bad Request for url: http://taskcluster/queue/v1/task/ZFeJApOhR5GO7Lxjw45MHg

The rerun failed because it seems to depend on the decision task:
https://treeherder.mozilla.org/logviewer.html#?job_id=206973485&repo=try

KeyError: u'index path gecko.v2.try.pushlog-id.308584.decision not found'

Please restore the rerunability of gecko decision tasks.
Generally you don't want to rerun a decision task, since it re-creates the task in place.  In this case, if the re-run had succeeded, then all those jobs it created before it failed would run twice.  A retrigger is a better choice.  That aside, it looks like this is due to a merge error:

def retrigger_decision_action(parameters, graph_config, input, task_group_id, task_id, task):
    decision_task_id, full_task_graph, label_to_taskid = fetch_graph_and_labels(
        parameters, graph_config)                                                                                                                                                                                                                                                                                                                                            
    """For a single task, we try to just run exactly the same task once more.
    It's quite possible that we don't have the scopes to do so (especially for
    an action), but this is best-effort."""

that bit of code got wedged in before the docstring, and isn't necessary.
Component: General → Task Configuration
Product: Taskcluster → Firefox Build System
Attached patch bug1501048.patchSplinter Review
Assignee: nobody → dustin
Attachment #9019133 - Flags: review?(bstack)
Attachment #9019133 - Flags: review?(bstack) → review+
https://hg.mozilla.org/mozilla-central/rev/6fcb74d1393c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.