Closed Bug 1501056 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13657 - WebAssembly: Add tests for invalid code arguments.

Categories

(Core :: JavaScript: WebAssembly, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13657 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13657
Details from upstream follow.

Ms2ger <Ms2ger@gmail.com> wrote:
>  WebAssembly: Add tests for invalid code arguments.
>  
>
Component: web-platform-tests → JavaScript Engine: JIT
Product: Testing → Core
Component: JavaScript Engine: JIT → Javascript: Web Assembly
Ran 13 tests and 92 subtests
OK     : 10
PASS   : 90
FAIL   : 2

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/wasm/jsapi/constructor/compile.any.html
    Invalid code: FAIL
/wasm/jsapi/constructor/compile.any.worker.html
    Invalid code: FAIL

Tests that are disabled for instability:
/wasm/jsapi/constructor/compile.any.js
/wasm/jsapi/constructor/instantiate.any.js
/wasm/jsapi/module/constructor.any.js
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f5beb3bf504
[wpt PR 13657] - WebAssembly: Add tests for invalid code arguments., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab51b28ab2a6
[wpt PR 13657] - Update wpt metadata, a=testonly
Backed out for causing SM build bustages on wasm/jsapi/constructor/compile.any.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=busted&revision=11795dee468927f39b56065389619d40bc24beda&searchStr=spider&selectedJob=210981099

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=210981099&repo=mozilla-inbound&lineNumber=135664

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/991a49ec5a1f2a0095b68c59dbc1bc31927e027a

[task 2018-11-10T09:37:04.233Z] TEST-PASS | wasm/jsapi/constructor/compile.any.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.3 s]
[task 2018-11-10T09:37:04.233Z] {"action": "test_start", "jitflags": [], "pid": 8698, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "wasm/jsapi/constructor/compile.any.js", "thread": "main", "time": 1541842623.97047}
[task 2018-11-10T09:37:04.233Z] {"action": "test_end", "extra": {"jitflags": [], "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "pid": 8698, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "PASS", "test": "wasm/jsapi/constructor/compile.any.js", "thread": "main", "time": 1541842624.233625}
[task 2018-11-10T09:37:04.233Z] TEST-UNEXPECTED-FAIL | wasm/jsapi/constructor/compile.any.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") | assert_throws: function "() => WebAssembly.compile(buffer)" did not throw [0.3 s]
[task 2018-11-10T09:37:04.234Z] {"action": "test_start", "jitflags": [], "pid": 8698, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "test": "wasm/jsapi/constructor/compile.any.js", "thread": "main", "time": 1541842623.970794}
[task 2018-11-10T09:37:04.234Z] {"action": "test_end", "extra": {"jitflags": [], "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so"}, "jitflags": [], "message": "assert_throws: function \"() => WebAssembly.compile(buffer)\" did not throw", "pid": 8698, "shell_args": "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so", "source": "jstests", "status": "FAIL", "test": "wasm/jsapi/constructor/compile.any.js", "thread": "main", "time": 1541842624.233949}
[task 2018-11-10T09:37:04.234Z] TEST-PASS | wasm/jsapi/constructor/compile.any.js | (args: "--dll /builds/worker/workspace/breakpad-tools/libbreakpadinjector.so") [0.3 s]
Flags: needinfo?(Ms2ger)
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a2c12f8f582
[wpt PR 13657] - WebAssembly: Add tests for invalid code arguments., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f9cb87a79d5
[wpt PR 13657] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/0a2c12f8f582
https://hg.mozilla.org/mozilla-central/rev/3f9cb87a79d5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Flags: needinfo?(Ms2ger)
You need to log in before you can comment on or make changes to this bug.