1501088 - Google Translate returns ' instead of actual quotes '

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Théo Chevalier]

Google Translate seem to replace straight quotes with ' in the TM tab. It’s quite visible in French for instance, since the language is heavily using them.

Example here: https://pontoon.mozilla.org/fr/engagement/emails/2018/fundraising_oct.lang/?string=191537

I don’t know if it’s something we can fix, but filing a bug in case we can. It could be Bing would have done the same, but they used curly quotes ’

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1110

Comment 2

[Matjaz Horvat [:mathjazz]]

I've deployed a patch to stage, which passes "text" instead of the default "html" as the source string "format". That fixes the problem, but on the other hand translates HTML tags, e.g. <name> becomes <nom>.

:tchevalier, I'd like to ask you to test the behaviour on stage (patch deployed) and compare it with prod (old code) to see which one should we keep.

Comment 3

[Théo Chevalier]

Thanks Matjaz!

After a quick test it seems both versions have their own downsides, it’s really hard to tell which is better.


Current behavior:

&brandShortName; > & brandShortName;

<a data-l10n-name="url"> (no change)

Permission denied for <%1$S> to get property %2$S.%3$S from <%4$S>.
Autorisation refusée à &lt;% 1 $ S&gt; d&#39;obtenir la propriété% 2 $ S.% 3 $ S à partir de &lt;% 4 $ S&gt;.



New behavior, with the patch:

&brandShortName; > & brandShortName; (still an extra space, but looks better)

For things like tags with attributes and values (like <a data-l10n-name="url">) it seem to behave without consistency: sometimes keeping it as in English, sometimes translating the value, sometimes adding a space in the attribute, etc. But at first glance, in most cases they are not changed.

Permission denied for <%1$S> to get property %2$S.%3$S from <%4$S>.
Autorisation refusée à <% 1 $ S> d'obtenir la propriété% 2 $ S.% 3 $ S à partir de <% 4 $ S>.

NOTE: In this case it seems it breaks the Machinery tab, you can’t click on any suggestion.

Works, you can click on Google Translate suggestion: https://pontoon.mozilla.org/fr/firefox/all-resources/?search=%3C&string=70137
Broken, you can’t click on Google Translate suggestion: https://mozilla-pontoon-staging.herokuapp.com/fr/firefox/all-resources/?search=%3C&string=70137

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/fe85f6a52d592d8958da575bd8ab8bdcd44d4a8b
Fix bug 1501088: Use text format for Google Translate (#1110)

Comment 5

[Jim Blandy :jimb]

Attachment: Bug 1501088: Fix DebugAPI::slowPathTraceGeneratorFrame's justification for calling TraceCrossCompartmentEdge. r?loganfsmyth

Comment 6

[Phabricator Automation]

Comment on attachment 9113329 [details]
Bug 1501088: Fix DebugAPI::slowPathTraceGeneratorFrame's justification for calling TraceCrossCompartmentEdge. r?loganfsmyth

Revision D55737 was moved to bug 1601088. Setting attachment 9113329 [details] to obsolete.