Closed Bug 1501101 Opened 6 years ago Closed 6 years ago

In multimessage view, toolbar button text is white

Categories

(Thunderbird :: Message Reader UI, defect)

Product:
Thunderbird
Component:
Message Reader UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird64 fixed, thunderbird65 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 65.0
Tracking Flags:
Tracking Status
thunderbird64 --- fixed
thunderbird65 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(2 files, 2 obsolete files)

really helpful buttons
5.89 KB, image/png
Details
1501101-multimessage-toolbar-3.diff
2.40 KB, patch
darktrojan
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
Attached image really helpful buttons — 
      No description provided.
Looks like your last fix in bug 1419133 was defeated by bug 1493280.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9019179 - Flags: review?(richard.marti)
Comment on attachment 9019179 [details] [diff] [review]
1501101-multimessage-toolbar-1.diff

Please can you do this on all platforms? The problem exists on all.
Attachment #9019179 - Flags: review?(richard.marti)
As you wish.
Attachment #9019179 - Attachment is obsolete: true
Attachment #9019522 - Flags: review?(richard.marti)
Comment on attachment 9019522 [details] [diff] [review]
1501101-multimessage-toolbar-2.diff

Review of attachment 9019522 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: mail/themes/windows/mail/multimessageview.css
@@ +33,5 @@
>    background-image: url("chrome://messenger/skin/icons/flag-col.png");
>  }
>  
>  .toolbarbutton-1.msgHeaderView-button {
> +  color: -moz-dialogtext !important;

Not needed, but when you land it, could you change the casing to -moz-DialogText?
Attachment #9019522 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/af375c660457
Fix text contrast on buttons in multimessageview's header. r=Paenglab
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Comment on attachment 9019613 [details] [diff] [review]
1501101-multimessage-toolbar-3.diff

Worth uplifting, if we're going to have another 64 beta.
Attachment #9019613 - Flags: approval-comm-beta?
Had I known earlier, it would be in the current beta built on the 26th.
Attachment #9019613 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #9019522 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: