Closed Bug 1501110 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13665 - Web Locks API: Fix IDL glitch

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13665 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13665
Details from upstream follow.

Joshua Bell <jsbell@chromium.org> wrote:
>  Web Locks API: Fix IDL glitch
>  
>  A callback defined in Web IDL should take a nullable argument. We
>  don't enforce this in our bindings code and it can't be introspected
>  from JS so this is not a testable or web-facing change, just aligning
>  the code with a spec fix.
>  
>  Spec issue: https://github.com/WICG/web-locks/issues/51
>  Spec link: https://wicg.github.io/web-locks/#callbackdef-lockgrantedcallback
>  
>  Change-Id: Icc2e076f62e45629a283d0039e2be30b4a6826c4
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1294421
>  WPT-Export-Revision: 5054a52bdc0400af37d59ca8d9e27db923a7e907
Ran 4 tests and 128 subtests
OK     : 4
PASS   : 8
FAIL   : 120
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc019e5de383
[wpt PR 13665] - Web Locks API: Fix IDL glitch, a=testonly
https://hg.mozilla.org/mozilla-central/rev/cc019e5de383
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.