1501178 - 4.75% build times (linux64) regression on push c43c91d2b97b (Mon Oct 22 2018)

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=80361808cf668648a20a3da2bdafb62ffbe04dd4&tochange=c43c91d2b97b1d1b230efdabce8b67d52e5cda27

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  5%  build times linux64 opt plain taskcluster-c4.4xlarge     1,580.87 -> 1,656.01


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=17018

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Chris Manchester (limited bugmail, email directly)]

I was actively investigating this and unaware there was a deadline to respond in order to avoid backout. This deadline would be good to include in the bug report/needinfo so people are aware of the situation. Had I been, I certainly would have reported on my progress investigating.

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Chris Manchester (:chmanchester) from comment #1)
> I was actively investigating this and unaware there was a deadline to
> respond in order to avoid backout. This deadline would be good to include in
> the bug report/needinfo so people are aware of the situation. Had I been, I
> certainly would have reported on my progress investigating.


I'm addressing this. I filed bug 1503195 for that.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1501178 - Prioritize directories containing rust compilation in the make backend.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #2)
> (In reply to Chris Manchester (:chmanchester) from comment #1)
> > I was actively investigating this and unaware there was a deadline to
> > respond in order to avoid backout. This deadline would be good to include in
> > the bug report/needinfo so people are aware of the situation. Had I been, I
> > certainly would have reported on my progress investigating.
> 
> 
> I'm addressing this. I filed bug 1503195 for that.

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51f379d29373
Prioritize directories containing rust compilation in the make backend. r=nalexander

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/51f379d29373

Comment 8

[Ionuț Goldan [:igoldan]]

I confirm this got fixed:

== Change summary for alert #17249 (as of Mon, 29 Oct 2018 07:30:25 GMT) ==

Improvements:

8% build times linux64 opt plain taskcluster-m5d.4xlarge 1,438.39 -> 1,329.29

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17249