Closed Bug 1501180 Opened 3 years ago Closed 3 years ago

Make TextEditRules::Notify() hide input characters in password field via editor

Categories

(Core :: DOM: Editor, enhancement)

Product:
Core
Component:
DOM: Editor
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

Bug 1501180 - Make TextEditRules::Notify() hide input characters via editor instance
46 bytes, text/x-phabricator-request
Details | Review 
TextEditRules::Notify() is a method called by timer.  So, this won't be in the stack of editor handling an edit action.  This should call a method of editor class and editor class should handle it with TextEditRules.
TextEditRules::Notify() is callback of the timer.  Therefore, this won't be
in the stack while editor handles an edit action.  Then, TextEditRules
cannot access edit action data which will be put on the stack after fixing
bug 1465702.  So, it should do it after once calling a method of editor
instance (and editor instance should call back proper TextEditRules method).
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/ca2018e79dc0
Make TextEditRules::Notify() hide input characters via editor instance r=m_kato
https://hg.mozilla.org/mozilla-central/rev/ca2018e79dc0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.