Closed
Bug 1501180
Opened 2 years ago
Closed 2 years ago
Make TextEditRules::Notify() hide input characters in password field via editor
Categories
(Core :: DOM: Editor, enhancement)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
TextEditRules::Notify() is a method called by timer. So, this won't be in the stack of editor handling an edit action. This should call a method of editor class and editor class should handle it with TextEditRules.
Assignee | ||
Comment 1•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b2fc7ff03d99ac2819f3affdf1699336ae6cd87
Assignee | ||
Comment 2•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74b1a0aae74a1aabf03899305202e2cf6965a126
Assignee | ||
Comment 3•2 years ago
|
||
TextEditRules::Notify() is callback of the timer. Therefore, this won't be in the stack while editor handles an edit action. Then, TextEditRules cannot access edit action data which will be put on the stack after fixing bug 1465702. So, it should do it after once calling a method of editor instance (and editor instance should call back proper TextEditRules method).
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/ca2018e79dc0 Make TextEditRules::Notify() hide input characters via editor instance r=m_kato
Comment 5•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ca2018e79dc0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•