1501180 - Make TextEditRules::Notify() hide input characters in password field via editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

TextEditRules::Notify() is a method called by timer.  So, this won't be in the stack of editor handling an edit action.  This should call a method of editor class and editor class should handle it with TextEditRules.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b2fc7ff03d99ac2819f3affdf1699336ae6cd87

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=74b1a0aae74a1aabf03899305202e2cf6965a126

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1501180 - Make TextEditRules::Notify() hide input characters via editor instance

TextEditRules::Notify() is callback of the timer.  Therefore, this won't be
in the stack while editor handles an edit action.  Then, TextEditRules
cannot access edit action data which will be put on the stack after fixing
bug 1465702.  So, it should do it after once calling a method of editor
instance (and editor instance should call back proper TextEditRules method).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca2018e79dc0
Make TextEditRules::Notify() hide input characters via editor instance r=m_kato

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ca2018e79dc0