1501225 - [wpt-sync] Sync PR 13674 - Revert "Reland "bindings: Implement timers with V8Function""

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13674 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13674
Details from upstream follow.

Timothy Gu <[e-mail]> wrote:
>  Revert "Reland "bindings: Implement timers with V8Function""
>  
>  This reverts commit 17f4e7d2ec13d6112dfcd8aa253f340bdb00d395.
>  
>  Reason for revert: Still breaks ASAN
>  
>  Original change's description:
>  > Reland "bindings: Implement timers with V8Function"
>  > 
>  > This is a reland of 254369a5f6df06c2c6be067d14c2cb2a036ba173. It addresses bug
>  > 888025 by adding ASAN test expectations, as the relevant V8 feature does not
>  > yet support running on ASAN builds.
>  > 
>  > Original change's description:
>  > > bindings: Implement timers with V8Function
>  > >
>  > > This fixes bug 866610 by using the IDL infrastructure to properly enter
>  > > the v8::Context before calling the registered callback.
>  > >
>  > > Also ensure eager finalization of ScheduledAction in DOMTimer to
>  > > prevent a memory leak. Added two more effective DCHECKs to confirm.
>  > >
>  > > Bug: 866610
>  > > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
>  > > Reviewed-on: https://chromium-review.googlesource.com/1220486
>  > > Reviewed-by: Nate Chapin \<[e-mail]>
>  > > Reviewed-by: Yuki Shiino \<[e-mail]>
>  > > Reviewed-by: Hitoshi Yoshida \<[e-mail]>
>  > > Commit-Queue: Timothy Gu \<[e-mail]>
>  > > Cr-Commit-Position: refs/heads/master@{#593108}
>  > 
>  > TBR=[e-mail]
>  > 
>  > Bug: 866610, 888025
>  > Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a
>  > Reviewed-on: https://chromium-review.googlesource.com/c/1239624
>  > Reviewed-by: Nate Chapin \<[e-mail]>
>  > Reviewed-by: Hitoshi Yoshida \<[e-mail]>
>  > Reviewed-by: Kentaro Hara \<[e-mail]>
>  > Reviewed-by: Yuki Shiino \<[e-mail]>
>  > Commit-Queue: Timothy Gu \<[e-mail]>
>  > Cr-Commit-Position: refs/heads/master@{#601830}
>  
>  TBR=[e-mail],[e-mail],[e-mail],[e-mail],[e-mail]
>  
>  Change-Id: Ie4f45dfcc1adcc2ac3469eab99dba813723288f4
>  No-Presubmit: true
>  No-Tree-Checks: true
>  No-Try: true
>  Bug: 866610, 888025
>  Reviewed-on: https://chromium-review.googlesource.com/c/1296057
>  Commit-Queue: Timothy Gu \<[e-mail]>
>  Reviewed-by: Kentaro Hara \<[e-mail]>
>  Cr-Commit-Position: refs/heads/master@{#601864}
>

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 13674 applied with additional changes from upstream: c66102aa297d196c8c24079b6f91b67fd9aa9e90, 60d9a09fcf6ea0244db9433198ef8cbce23a1ef4

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c7ba3e7c0e8245a7aec327b3e17d5a963b7dfb8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb4df8a62231
[wpt PR 13674] - Revert "Reland "bindings: Implement timers with V8Function"", a=testonly

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/cb4df8a62231