Closed Bug 1501290 Opened 7 years ago Closed 7 years ago

Taskcluster-Treeherder should handle schema errors internally

Categories

(Taskcluster :: Operations and Service Requests, task)

Product:
Taskcluster
Component:
Operations and Service Requests
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

These are currently sent to Sentry. Probably just logging them as ignored is sufficient.
https://sentry.prod.mozaws.net/operations/taskcluster-treeherder/issues/3515947/ Error: Message validation failed. Schema Validation Failed! Rejecting Schema: https://schemas.taskcluster.net/treeherder/v1/pulse-job.json# Errors: * data.origin should NOT have additional properties: "revision_hash" * data.origin should have required property 'revision' * data.origin should NOT have additional properties: "revision_hash" * data.origin should NOT have additional properties: "pushLogID" * data.origin.kind should be equal to one of the allowed values * data.origin should have required property 'revision' * data.origin should match exactly one schema in oneOf /app/src/handler.js in Handler.publishJobMessage at line 198:28
The spate of these errors occurred due to YAML errors in .taskcluster.yml, as a result of the "error task" hard-coded into mozilla-taskcluster.
Cam indicated that such tasks wouldn't be supported at this time, anyway, as revision_hash is no longer supported. So, I've updated the tc-treeherder patch to just fail on such tasks.
Both landed. I'll try a bogus push to try.
Component: Operations → Operations and Service Requests
You need to log in before you can comment on or make changes to this bug.