Closed
Bug 1501316
Opened 7 years ago
Closed 7 years ago
Cleanup TableSwitch handling in Baseline to no longer use an IC
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: tcampbell, Assigned: jandem)
References
Details
Attachments
(1 file)
Currently the TableSwitchIC is doing what we would otherwise do directly in the mainline code. It seems this was done for memory savings. Another approach would be to treat this like our other helper-stub / trampolines.
At the same time, we should look at moving the address tables to the BaselineScript itself since they should be well known during compile. This brings them more aligned with our yeildAndAwait table.
| Assignee | ||
Updated•7 years ago
|
Assignee: tcampbell → jdemooij
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•7 years ago
|
||
To not affect Baseline code size too much, this adds a trampoline for the
double-to-int32 Value conversion.
Depends on D11019
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7283b13fd2d2
Remove Baseline's TableSwitch IC, use resume entries instead. r=tcampbell
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•