Closed Bug 1501316 Opened 2 years ago Closed 2 years ago

Cleanup TableSwitch handling in Baseline to no longer use an IC

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: tcampbell, Assigned: jandem)

References

Details

Attachments

(1 file)

Currently the TableSwitchIC is doing what we would otherwise do directly in the mainline code. It seems this was done for memory savings. Another approach would be to treat this like our other helper-stub / trampolines.

At the same time, we should look at moving the address tables to the BaselineScript itself since they should be well known during compile. This brings them more aligned with our yeildAndAwait table.
We need this for bug 1499644 :)
Blocks: 1499644
Depends on: 1504979
Assignee: tcampbell → jdemooij
Status: NEW → ASSIGNED
To not affect Baseline code size too much, this adds a trampoline for the
double-to-int32 Value conversion.

Depends on D11019
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7283b13fd2d2
Remove Baseline's TableSwitch IC, use resume entries instead. r=tcampbell
https://hg.mozilla.org/mozilla-central/rev/7283b13fd2d2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.