Closed Bug 1501360 Opened 11 months ago Closed 11 months ago

Port bug 1493844 -Replace use of the "caption" and "groupbox" bindings in C-C

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: jorgk, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Version: 38 Branch → Trunk
Attached patch 1501360-groupbox-caption.patch (obsolete) — Splinter Review
This should do it. The prefs should look like before. On the native dialogs like the edit message filter dialog, the groupbox isn't 100% like before: I can't move the caption on the groupbox top border. When I do this, the whole top border would be hidden. But I think the actual look should also be okay.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9019601 - Flags: review?(jorgk)
Comment on attachment 9019601 [details] [diff] [review]
1501360-groupbox-caption.patch

Review of attachment 9019601 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, did you do that by hand?

::: mail/components/preferences/messengerLanguages.xul
@@ -22,5 @@
>  
>    <script type="application/javascript" src="chrome://global/content/preferencesBindings.js"/>
>    <script type="application/javascript" src="chrome://messenger/content/preferences/messengerLanguages.js"/>
>  
> -  <vbox id="messengerLanguagesDialogPane"

Why are we removing this? What about:

#messengerLanguagesDialogPane {
  min-height: 360px;
}

in aboutPreferences.css?
(In reply to Jorg K (GMT+2) from comment #2)
> Comment on attachment 9019601 [details] [diff] [review]
> 1501360-groupbox-caption.patch
> 
> Review of attachment 9019601 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, did you do that by hand?

Yes, there where too much different cases. I hope I touched all occurrences.

> ::: mail/components/preferences/messengerLanguages.xul
> @@ -22,5 @@
> >  
> >    <script type="application/javascript" src="chrome://global/content/preferencesBindings.js"/>
> >    <script type="application/javascript" src="chrome://messenger/content/preferences/messengerLanguages.js"/>
> >  
> > -  <vbox id="messengerLanguagesDialogPane"
> 
> Why are we removing this? What about:
> 
> #messengerLanguagesDialogPane {
>   min-height: 360px;
> }
> 
> in aboutPreferences.css?

Good catch. This was one of the first files I changed and followed m-c. Later I noticed this changes arn't needed on our side but forgot to remove it in this file.
Attachment #9019601 - Attachment is obsolete: true
Attachment #9019601 - Flags: review?(jorgk)
Attachment #9019626 - Flags: review?(jorgk)
Comment on attachment 9019626 [details] [diff] [review]
1501360-groupbox-caption.patch v2

Looks OK on visual inspection. I'll fix the merge conflict with the progress meter bug myself.
Attachment #9019626 - Flags: review?(jorgk) → review+
Oh, I also tried it on one panel ;-) - I preferred the caption to be on the groupbox top border.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d79573211d8f
Port bug 1493844: Replace use of the "caption" and "groupbox" bindings in C-C. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.