1501373 - Firefox no longer respects Windows 10 accent color for theme

Status: RESOLVED DUPLICATE of bug 1474591

(Firefox :: Theme, defect)

Description

[ross]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Windows 10 Pro x64 with the latest October update.
Windows 10 theme is set to "Dark"
Firefox 63 x64 is installed with Firefox theme set to "Default"


Actual results:

1. The title bar and tab background colors are now pitch black. 
2. The rest of the toolbar is now dark gray and looks particularly bad with a lot of extension icons.
3. There is  no difference in color when the window is active/inactive.
4. Hovering over the "Default" theme in the customization window displays the expected results, but then it reverts back to all black when selected.


Expected results:

I expect to see the Firefox theme identical to how it was prior to version 63: The title bar and tab backgrounds using the Windows 10 accent color and the rest of the toolbar using the old light gray color.

The only way I've found to get that behavior back is by changing the Windows 10 theme to "Light", except that's undesirable.

Comment 1

[Keith Greene]

I also have this issue, also on Win 10 x64 Pro, however, my Windows 10 theme is not set to Dark, it is set to Custom. My experience is exactly the same, though, down to the hover behavior.

Comment 2

[Alice0775 White]

@ross and @Kelth
Could you please re-test with Beta or Nightly[1] after backup current profile? 
ATTENTION: Do not use the current profile what you normally use, It will be incompatible.

[1]
https://www.mozilla.org/en-US/firefox/channel/desktop/

Comment 3

[Keith Greene]

(In reply to Alice0775 White from comment #2)
> @ross and @Kelth
> Could you please re-test with Beta or Nightly[1] after backup current
> profile? 
> ATTENTION: Do not use the current profile what you normally use, It will be
> incompatible.
> 
> [1]
> https://www.mozilla.org/en-US/firefox/channel/desktop/

I just tested in Nightly and the problem persists, however, there appear to be some check boxes at the bottom of the theme rollout that I hadn't noticed before. One of those is marked "title bar" and when I check that, the window title bar changes to the correct color. I can then switch to the light theme to get *close* to what I am looking for.

Comment 4

[Dão Gottwald [:dao]]

(In reply to ross from comment #0)
> User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0)
> Gecko/20100101 Firefox/63.0
> 
> Steps to reproduce:
> 
> Windows 10 Pro x64 with the latest October update.
> Windows 10 theme is set to "Dark"
> Firefox 63 x64 is installed with Firefox theme set to "Default"
> 
> 
> Actual results:
> 
> 1. The title bar and tab background colors are now pitch black. 

This is intended behavior when enabling Windows 10 dark mode.

> 2. The rest of the toolbar is now dark gray and looks particularly bad with
> a lot of extension icons.

This doesn't seem like an actionable issue.

> 3. There is  no difference in color when the window is active/inactive.
> 4. Hovering over the "Default" theme in the customization window displays
> the expected results, but then it reverts back to all black when selected.

These sound like legitimate issues, but they should be filed separately so they can be evaluated and addressed properly.

Comment 5

[ross]

(In reply to Alice0775 White from comment #2)
> @ross and @Kelth
> Could you please re-test with Beta or Nightly[1] after backup current
> profile? 
> ATTENTION: Do not use the current profile what you normally use, It will be
> incompatible.
> 
> [1]
> https://www.mozilla.org/en-US/firefox/channel/desktop/

I can confirm that a fresh install of Nightly has the same issues.

Comment 6

[ross]

(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to ross from comment #0)
> > User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0)
> > Gecko/20100101 Firefox/63.0
> > 
> > Steps to reproduce:
> > 
> > Windows 10 Pro x64 with the latest October update.
> > Windows 10 theme is set to "Dark"
> > Firefox 63 x64 is installed with Firefox theme set to "Default"
> > 
> > 
> > Actual results:
> > 
> > 1. The title bar and tab background colors are now pitch black. 
> 
> This is intended behavior when enabling Windows 10 dark mode.

Are you saying that the intended behavior of the "Default" Firefox theme is to disallow the use of the Windows accent color when the Windows Dark theme is enabled, but to allow for that same "Default" theme to use the Windows accent color when the Windows Light them is enabled? That seems counter-intuitive, especially since the Windows accent color is set independently of the Dark/Light theme.

Comment 7

[Keith Greene]

Also note that this behavior happens when the Windows theme is set to Custom, so it's NOT just Windows Dark that does it.

Comment 8

[Dão Gottwald [:dao]]

(In reply to ross from comment #0)
> 4. Hovering over the "Default" theme in the customization window displays
> the expected results, but then it reverts back to all black when selected.

Filed bug 1502096 on this.

Comment 9

[[:philipp]]

a workaround would be creating a new integer preference in about:config named "ui.systemUsesDarkTheme" and set to "0" (needs a restart to take effect)

Comment 10

[u620069]

(In reply to Dão Gottwald [::dao] from comment #4)

(In reply to ross from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0)
Gecko/20100101 Firefox/63.0

Steps to reproduce:

Windows 10 Pro x64 with the latest October update.
Windows 10 theme is set to "Dark"
Firefox 63 x64 is installed with Firefox theme set to "Default"

Actual results:

1. The title bar and tab background colors are now pitch black.

This is intended behavior when enabling Windows 10 dark mode.

May we get an explanation of why this is intended for the default Firefox theme too? If the user turns accent color on, all other application windows support it, even in dark mode. I don't understand why the default Firefox theme should suppport it in Windows light mode but no in Windows dark mode. If the user does not want colors, they can always switch to Firefox Dark theme, or they can turn off accent color altogether in Windows's Colors settings.