Closed
Bug 1501387
Opened 2 years ago
Closed 2 years ago
Handlify Stream.h
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
Attachments
(1 file)
The API presented in js/public/Stream.h is inconsistent. Sometimes parameters are handles; other times raw pointers. Sometimes the pointers are `const JSObject *`. We should use handles whenever a `cx` is present, and not `const JSObject *` as that doesn't really express any helpful or dependable API guarantee. As it turns out, all existing code passes rooted pointers anyway, so no downstream code needs to be changed when handlifying this stuff.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → jorendorff
Priority: -- → P1
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ca97be22a38 Handlify Streams.h and avoid using `const JSObject*`. r=tcampbell
Comment 3•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ca97be22a38
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•