Closed Bug 1501387 Opened 2 years ago Closed 2 years ago
46 bytes, text/x-phabricator-request
|Details | Review|
The API presented in js/public/Stream.h is inconsistent. Sometimes parameters are handles; other times raw pointers. Sometimes the pointers are `const JSObject *`. We should use handles whenever a `cx` is present, and not `const JSObject *` as that doesn't really express any helpful or dependable API guarantee. As it turns out, all existing code passes rooted pointers anyway, so no downstream code needs to be changed when handlifying this stuff.
Assignee: nobody → jorendorff
Priority: -- → P1
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/9ca97be22a38 Handlify Streams.h and avoid using `const JSObject*`. r=tcampbell
You need to log in before you can comment on or make changes to this bug.