1501390 - [RTL] With tabs in title disabled, the title bar context menu is LTR

Status: NEW

(Core :: Widget: Win32, defect, P2)

Description

[Itiel]

This is probably a dupe of an older bug, just couldn't find it.

STR:
1. (Not sure if this one is a necessity) Be on an RTL Windows system
2. Change intl.uidirection to 1
3. Menu > Customize... > Enable "Title Bar"
4. Right click the title bar

AR:
Context menu is LTR.

ER:
Should be RTL.

(fwiw, built-in Windows applications behave correctly, including other non-Windows ones)

Comment 1

[Itiel]

Attachment: Screenshot

Comment 2

[:Gijs (he/him)]

I think this is a system menu, so I dunno how we're meant to tell it to appear RTL (or how we're managing to tell it to appear LTR today)... agashlin, do you know?

Comment 3

[:Gijs (he/him)]

Moving this over to widget at least for now - if this does need a frontend change we can move it back, and/or maybe this wants being in Core :: I18n or something?

Comment 4

[Itiel]

(In reply to :Gijs (he/him) from comment #2)
> I think this is a system menu, so I dunno how we're meant to tell it to
> appear RTL (or how we're managing to tell it to appear LTR today)...

Yes, this is a system menu. I think this is the default behaviour if it's not specified in the code.
See attached for how the menu appears on RTL'd TeamViewer (the same can be said about other properly RTL'd apps like CDBurnerXP).

Comment 5

[Itiel]

Attachment: TeamViewer right click screenshot

Comment 6

[Itiel]

This is from WinRAR's developer on how it should be done:
> I think, it depends on SetProcessDefaultLayout(LAYOUT_RTL) call:
> WinRAR calls this function:
> https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-setprocessdefaultlayout
> before creating the main window.

Comment 7

[Jim Mathies [:jimm]]

Adam is pretty busy with update work right now, but he should have some cycles for this in Q1.

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

I kept meaning to get back to this, but I'm not going to have time to look into it, sorry for letting it sit for so long. Jim, could you take a look or redirect?