150140 - implement full /whois syntax and /wii shortcurt

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[Alexander Nedotsukov]

Currently chatzila's /whois can lookup informatioin only on local irc server
(the one chatzilla connected to). This prevents to see the peer user idle and
server info in case he/she connected to another server (of the same network).
See rfc1459 for the full /whois syntax.
/wii is stands for whois idle (as in bitchx irc client) and just a "whois nick
nick" command shortcurt.

Comment 1

[Alexander Nedotsukov]

My be it's reasonable to add an option to chatzilla's prerfs wich selects whois
method to be used in the UI handlers (eg. whois from contetxt menu will result
in /whois nick nick or /whois nick)?

Comment 2

[James Ross]

(In reply to comment #1)
> My be it's reasonable to add an option to chatzilla's prerfs wich selects whois
> method to be used in the UI handlers (eg. whois from contetxt menu will result
> in /whois nick nick or /whois nick)?

"/whois nick nick" is not mentioned in the spec. What does it do and why do you
want it?

Comment 3

[Alexander Nedotsukov]

(In reply to comment #2)
> (In reply to comment #1)
> > My be it's reasonable to add an option to chatzilla's prerfs wich selects whois
> > method to be used in the UI handlers (eg. whois from contetxt menu will result
> > in /whois nick nick or /whois nick)?
> 
> "/whois nick nick" is not mentioned in the spec. What does it do and why do you
> want it?
    Spec says that full whois syntax is WHOIS [ <target> ] <mask> *( "," <mask>
). At the moment I wrote report it was impossible to send <target> with
ChatZilla's /whois. That what I said. And as I also said /whois <nick> <nick> is
a full form of /wii command in bitchx. It sends WHOIS <nick> <nick> command to
server which seems to be widely supported extension. <nick> at the <target>
place just says request on server where that user logged in. Imho this enables
client request full data in one step. Please read RFC2812 3.6.2 to understand
why full WHOIS syntax may be important.

Comment 4

[Justin Turner Arthur]

Implementation of the full whois syntax would depend on the resolution of bug
262336, as well as any command such as the here-proposed WII command that would
rely on a properly implemented whois command.

Comment 5

[James Ross]

(In reply to comment #3)
> Please read RFC2812 3.6.2 to understand why full WHOIS syntax may be important.

Of course I've read the spec. I asked what "WHOIS nick nick" was since that is
NOT in the spec (even though it may well be a widly adopted extension). There is
no reason a command should match the protocol command exactly - you might as
well just use telnet.

"/wii nick" --> "WHOIS nick nick" is easilly do-able (and actually might make
sense), and "/whois nick nick" being specially allowed is possible (though I
dislike this format myself).

Comment 6

[timeless]

silver: /whois silver silver is becoming much more important now that
irc.mozilla.org has two servers.

Comment 7

[James Ross]

Attachment: Add /wii and actually make /whois work right

Turns out /whois was actually ignoring all but the first param *anyway*, so it
could never have worked right. This patch not only fixes that, but allows you
to repeat any nickname to get a /wii on them instead of the normal /whois. It
also adds a /wii command.

Comment 8

[Robert Ginda]

Comment on attachment 168372 [details] [diff] [review]
Add /wii and actually make /whois work right

r=rginda

Comment 9

[James Ross]

Checked in --> FIXED.

This feature will be available in the next public release of ChatZilla, planned
to be 0.9.67 (hopefully not long now).

Comment 10

[[e-mail]]

Does this include changes to the auto-whois when you open a query tab?

Comment 11

[James Ross]

No, this doesn't touch the auto-whois code at all.