Closed Bug 1501405 Opened Last year Closed Last year
Renewal of Web
Extensions storage .sync histograms that expired on Firefox 64
2.61 KB, text/plain
46 bytes, text/x-phabricator-request
|Details | Review|
The STORAGE_SYNC_* telemetry histograms are the ones related to the storage.local.sync API, they are currently set to expire in Firefox 64 (). We are going to renew them, as they provide telemetry data related to the performance of the storage.sync API that is not collected by any other of our telemetry probes. We should also update the `alert_email` to include at least an email address related to the Addons Team (e.g. the addons-dev-internal and mine as the other webextensions histograms). : https://telemetry.mozilla.org/probe-dictionary/?search=storage_sync_
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Iteration: --- → 65.1 (Nov 2)
Priority: -- → P1
In the attached file, the Data Review request for the renewal of the existing STORAGE_SYNC_* telemetry probes.
Attachment #9019973 - Flags: review?(chutten)
Comment on attachment 9019973 [details] request-data-review-bug-1501405-renew-storage-sync-histograms.md DATA COLLECTION REVIEW RESPONSE Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. Standard Telemetry mechanisms apply. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available. Yes. Standard Telemetry mechanisms apply. If the request is for permanent data collection, is there someone who will monitor the data over time? N/A, expires in 67. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1 Is the data collection request for default-on or default-off? Default on, all channels. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. :rpl is responsible for renewing or removing these probes before they expire in Firefox 67. --- Result: datareview+
Attachment #9019973 - Flags: review?(chutten) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f7495a92f91e Renewal of WebExtensions storage.sync histograms expired on Firefox 64. r=chutten
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag. Thanks!
I'm setting qe-verify-: Given that this patch is renewing existing histograms by just updating the `expires_in_version` properties in the `toolkit/components/telemetry/Histograms.json` file, an additional manual verification may not be worth it. Also, from the telemetry dashboard is already visible that, after the missing data related to Firefox 64, the histograms data for Firefox 65 is now starting to be visible there again.
Flags: needinfo?(lgreco) → qe-verify-
Comment on attachment 9019974 [details] Bug 1501405 - Renewal of WebExtensions storage.sync histograms expired on Firefox 64. r?chutten! [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: None User impact if declined: No direct impact on the user, but the telemetry data for Firefox 64 related to the "storage.sync API" histograms will be missing (as they have been missing for nightly 64). Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): This patch extends the storage.sync histograms by changing the expire version in the Histograms.json file, but besides that there are no additional changes. String changes made/needed:
Attachment #9019974 - Flags: approval-mozilla-beta?
Comment on attachment 9019974 [details] Bug 1501405 - Renewal of WebExtensions storage.sync histograms expired on Firefox 64. r?chutten! telemetry expiry extensions, approved for 64.0b10
Attachment #9019974 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.