1501496 - Don't do blocking IPC calls on each accessible event

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

We currently send some info about the accessible with the event when dispatching to platform. This means we do a couple of synchronous IPC calls, specifically to get the accessible's name to populate the event's text field.

I checked, and Chrome doesn't do that anymore. TalkBack relies on the text on the actual accessible node it retrieves from the event. If we remove that text as well, it will be a couple of less synchronous calls we make.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1501496 - Don't send accessible GeckoBundle in sendEvent, class names is enough. r?Jamie!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ff7a3acb857
Don't send accessible GeckoBundle in sendEvent, class names is enough. r=Jamie

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6ff7a3acb857

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6ff7a3acb857

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 9019787 [details]
Bug 1501496 - Don't send accessible GeckoBundle in sendEvent, class names is enough. r?Jamie!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1479037

User impact if declined: Users may potentially experience slowdowns if they have accessibility enabled (screen reader, password manager, etc)

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: Bug 1502187, Bug 1479039, Bug 1507026, Bug 1506709

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It simplifies accessibility events, so things should be better.

String changes made/needed:

Comment 6

[Chris Peterson [:cpeterson]]

64=affected because Eitan says this fix should be uplifted to 64 Beta.

Comment 7

[Chris Peterson [:cpeterson]]

[geckoview:p1] because this bug blocks Focus 8.0.

Comment 8

[Eitan Isaacson [:eeejay]]

Note that this patch seems to fix an OOM in 64 found in bug 1508641.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9019787 [details]
Bug 1501496 - Don't send accessible GeckoBundle in sendEvent, class names is enough. r?Jamie!

approved for 64.0b12

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d901616bfe1a

Comment 11

[Chris Peterson [:cpeterson]]

status-geckoview64=fixed