Closed
Bug 1501537
Opened 6 years ago
Closed 6 years ago
[BinAST] Perform finishInitializerAssignment to name function
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
2.79 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
FPH::finishInitializerAssignment is not performed in BinAST, that results in the .name of function is not set in the following code: var f = function() {} print(f.name);
Assignee | ||
Comment 1•6 years ago
|
||
setInitializer is done inside finishInitializerAssignment, and finishInitializerAssignment does some more things which is necessary for naming function. also CSE-ed `binding->template as<NameNode>()` into variable.
Attachment #9019572 -
Flags: review?(dteller)
Attachment #9019572 -
Flags: review?(dteller) → review+
Assignee | ||
Comment 2•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2a70b31cc32e0e5b3fb358105ad660b4b9f42e6 Bug 1501537 - Name function in variable declaration initializer in BinAST. r=Yoric
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f2a70b31cc32
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•