Closed Bug 1501576 Opened Last year Closed 9 months ago

Add helper classes to emit bytecode for labelled statement

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Just like others (bug 1456006, bug 1456404).

support labelled statement, as a target for break/continue.
Blocks: 1455548

Factored out BytecodeEmitter::emitLabeledStatement body into LabelEmitter class.

Attachment #9035528 - Flags: review?(jwalden)
Comment on attachment 9035528 [details] [diff] [review]
Add LabelEmitter.

Review of attachment 9035528 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/frontend/LabelEmitter.cpp
@@ +13,5 @@
> +
> +using namespace js;
> +using namespace js::frontend;
> +
> +LabelEmitter::LabelEmitter(BytecodeEmitter* bce) : bce_(bce) {}

Might as well define this in the header if it's so small.
Attachment #9035528 - Flags: review?(jwalden) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
No longer depends on: 1521696
You need to log in before you can comment on or make changes to this bug.