1501632 - Return an unsubscribe function from SourceMapURLService.prototype.subscribe

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

The SourceMapURLService has a subscribe and an unsubscribe functions to respectively listen and stop listening for source map changes on a given location (url + line + column).
The unsubscribe function need to be called with the same parameters as the subscribe function, which means the consumer need to keep a reference to the callback function it passes to subscribe.

Returning an unsubscribe function from subscribe would make the process a bit more easier and future proof.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1501632 - Return an unsubscribe function from SourceMapURLService.prototype.subscribe; r?loganfsmyth.

The SourceMapURLService has a subscribe and an unsubscribe
functions to respectively listen and stop listening for
source map changes on a given location (url + line + column).
The unsubscribe function need to be called with the same
parameters as the subscribe function, which means the consumer
need to keep a reference to the callback.
By making the subscribe function return the unsubscribe function,
this makes things a bit easier.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8967e494e4e3
Return an unsubscribe function from SourceMapURLService.prototype.subscribe; r=loganfsmyth.

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8967e494e4e3