Closed Bug 1501659 Opened 6 years ago Closed 5 years ago

Unable to run tests against expired telemetry probes in developer builds (non-official)

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: chutten)

References

Details

Attachments

(3 files)

I was trying to simulate the failures in bug 1496764 (expired events telemetry probe), to prove out some other things.

However, I was unable to do this - the test would pass, even though the event was set for an old version in Events.yaml.

I eventually determined the only way for me to test this was to enable MOZILLA_OFFICIAL in my build configuration. It turns out that this code:

https://searchfox.org/mozilla-central/rev/a7f4d3ba4fbfe3efbde832869f1d672fce7122f6/toolkit/components/telemetry/app/TelemetryController.jsm#1034-1043

installs dynamic event probes over the top of the static ones, but doesn't take account of their expiries.

This means expired probes can not be tested without an "official" build.
We can probably check whether the probe is expired during JS registration. It will be a bit slow, but it will only happen on developer builds.
Assignee: nobody → chutten
Status: NEW → ASSIGNED
Points: --- → 2
Priority: -- → P1
When registering dynamic builtin scalars and events (Build Faster support) we
didn't check whether they were expired. Let's do that.
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0636b7fabe33
Expire expired dynamic builtin scalars and events r=janerik
Backout by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/948718214f0b
Backed out changeset 0636b7fabe33 for build bustages. CLOSED TREE
Fixed tests up for review.

Try push here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=641f5e738a1b5621205cf05403fc5bb5d4a1e31a
Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0d14569871f
Expire expired dynamic builtin scalars and events r=janerik
https://hg.mozilla.org/mozilla-central/rev/b0d14569871f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
See Also: → 1507175
The patch sometimes causes a crash soon after content process startup (bug 1507175), which isn't very nice. I've reverted the change, so this'll need another look.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Priority: P1 → P2
Priority: P2 → P1

When registering dynamic builtin scalars and events (Build Faster support) we
didn't check whether they were expired. Let's do that.

Land it on Monday.

Flags: needinfo?(jrediger)
Flags: needinfo?(jrediger)
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e789bbe66b4
Expire expired dynamic builtin scalars and events r=janerik
https://hg.mozilla.org/integration/autoland/rev/8a0ce29168db
Ensure child processes know which dynamic scalars were built-in. r=janerik
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla65 → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: