1501691 - Add close without save alert for Notifications Modal in Preferences

Status: NEW

(Firefox :: Settings UI, defect, P3)

Description

[Wellington Torrejais da Silva]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

- Open Browser Preferences
- Open Sites Notification preference modal
- Try to change notifications preference for a site
- Click out the window
- No message to close without save


---

Please close whiteout save alter after sites notifications config, or make auto save


Actual results:

Sometimes didn't remember to click in save button at modals 


Expected results:

Or auto save or confirm when go out modal without saving.

Comment 1

[Kanchan Kumari QA]

This bug is reproducible for me on 
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Clicking outside the notification setting window close the window and doesn't auto save the changes.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This most likely happens with other subdialogs that are not auto-save. I can also reproduce on the "Manage Cookies and Site Data" subdialog.

Comment 3

[Neha]

Hi, I would like to work on this.
Could this be assigned to me?
Thanks!

Comment 4

[Neha]

Attachment: Bug 1501691 - Adds close without save alert for Notifications Modal in Preferences r=johannh

Comment 5

[Johann Hofmann [:johannh]]

Huh, sorry, going through old bugs now, I seem to have missed your questions on the phab revision. I assume you're no longer active on the bug, so I'm unassigning you. Let me know if you want to pick it back up.

Comment 6

[Jayati Shrivastava]

Hi Johann! May I work on this?

Comment 7

[Johann Hofmann [:johannh]]

Hey Jayati, feel free to take a look. As you can see in the conversation on the patch Neha hit some issues though I feel like the general idea is already explained in https://phabricator.services.mozilla.com/D24604#725780. Please let me know if you have any questions.

Thanks!

Comment 8

[Johann Hofmann [:johannh]]

Unassigning for inactivity, let me know if you want to pick it back up.

Comment 9

[Anshul Sahai]

Hey! I would like to work on this issue.