Closed
Bug 1501718
Opened 6 years ago
Closed 6 years ago
Port Bug 1501404 - Part 7: Remove the XPCOM registration for nsSyncStreamListener (4 Xpcshell test failures, 11 MozMill failures)
Categories
(MailNews Core :: General, enhancement)
MailNews Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 65.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 4 obsolete files)
3.59 KB,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
Causes test failures: TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_detachToFile.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_mimemaltdetach.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | comm/mailnews/base/test/unit/test_quarantineFilterMove.js | xpcshell return code: 0 TEST-UNEXPECTED-FAIL | comm/mailnews/imap/test/unit/test_imapAttachmentSaves.js | xpcshell return code: 0 Running the first test locally I see: [JavaScript Error: "Cc['@mozilla.org/network/sync-stream-listener;1'] is undefined; can't access its "createInstance" property" {file: "c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/_tests/xpcshell/comm/mailnews/base/test/unit/test_detachToFile.js" line: 112}] https://hg.mozilla.org/mozilla-central/rev/89474459aeb8 We use it in JS: https://searchfox.org/comm-central/search?q=sync-stream-listener&case=false®exp=false&path= Geoff, could you restore this for us. I've see too much bustage in a single day already and there is more to file :-(
Flags: needinfo?(geoff)
Assignee | ||
Comment 1•6 years ago
|
||
Actually, it causes 11 MozMill failures as well: TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-reply-format-flowed.js | test-reply-format-flowed.js::test_reply_format_flowed TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-charset-upgrade.js | test-charset-upgrade.js::test_encoding_upgrade_html_compose TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-charset-upgrade.js | test-charset-upgrade.js::test_encoding_upgrade_plaintext_compose TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-drafts.js | test-drafts.js::test_content_language_header TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-drafts.js | test-drafts.js::test_remove_space_stuffing_format_flowed TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-image-display.js | test-image-display.js::test_cid_image_compose TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-forward-rfc822-attach.js | test-forward-rfc822-attach.js::test_forwarding_long_html_line_as_attachment TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-forward-rfc822-attach.js | test-forward-rfc822-attach.js::test_forwarding_feed_message_as_attachment TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-send-format.js | test-send-format.js::test_msg_convertibility TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-multipart-related.js | test-multipart-related.js::test_basic_multipart_related TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/tests/mozmill/composition/test-blocked-content.js | test-blocked-content.js::test_paste_file_urls EXCEPTION: Cc['@mozilla.org/network/sync-stream-listener;1'] is undefined; can't access its "createInstance" property at: test-compose-helpers.js line 522
Assignee | ||
Updated•6 years ago
|
Summary: Port Bug 1501404 - Part 7: Remove the XPCOM registration for nsSyncStreamListener → Port Bug 1501404 - Part 7: Remove the XPCOM registration for nsSyncStreamListener (4 Xpcshell test failures, 11 MozMill failures)
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Flags: needinfo?(geoff)
Attachment #9019781 -
Flags: review?(geoff)
Assignee | ||
Comment 4•6 years ago
|
||
Hi Valentin, M-C is busily removing XPCOM registration of things we use in JS. Mostly we can just restore the registration, but in this case, some functions need to be public.
Assignee: nobody → jorgk
Attachment #9019783 -
Flags: review?(valentin.gosu)
Assignee | ||
Updated•6 years ago
|
Attachment #9019755 -
Attachment is obsolete: true
Assignee | ||
Comment 5•6 years ago
|
||
Sorry about the noise, one word ("Make") missing from the commit message.
Attachment #9019783 -
Attachment is obsolete: true
Attachment #9019783 -
Flags: review?(valentin.gosu)
Attachment #9019784 -
Flags: review?(valentin.gosu)
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e6653caba99c6676a2232bbdc12da7556246b0a5 based on https://hg.mozilla.org/try/rev/365be2eda0e3e65a8aea3cfd8126cbd9676f19ca
Comment 7•6 years ago
|
||
Comment on attachment 9019784 [details] [diff] [review] 1501718-M-C-part.patch Review of attachment 9019784 [details] [diff] [review]: ----------------------------------------------------------------- You can use ::Create() instead. I'll comment in the other patch.
Attachment #9019784 -
Flags: review?(valentin.gosu) → review-
Comment 8•6 years ago
|
||
Comment on attachment 9019781 [details] [diff] [review] C-C part - 1501718-nsSyncStreamListener.patch (v2) Review of attachment 9019781 [details] [diff] [review]: ----------------------------------------------------------------- ::: common/src/nsCommonModule.cpp @@ +19,5 @@ > > NS_GENERIC_FACTORY_CONSTRUCTOR(TransactionManager) > NS_DEFINE_NAMED_CID(NS_TRANSACTIONMANAGER_CID); > > +NS_GENERIC_FACTORY_CONSTRUCTOR_INIT(nsSyncStreamListener, Init) Instead of this, you can define a factory method similar to [1] that calls nsSyncStreamListener::Create() [1] https://searchfox.org/mozilla-central/rev/72b1e834f384a2ffec6eb4ce405fbd4b5e881109/netwerk/build/nsNetModule.cpp#536
Attachment #9019781 -
Flags: feedback+
Assignee | ||
Comment 9•6 years ago
|
||
Thanks Valentin, interesting variation. I learn something new every day :-) I modernised CreateNewUnknownDecoderFactory() a by using NS_ENSURE_ARG_POINTER(). Apparently 'new' is infallible (well, control doesn't return if it fails internally), so no need to check for a non-null result either.
Attachment #9019781 -
Attachment is obsolete: true
Attachment #9019784 -
Attachment is obsolete: true
Attachment #9019781 -
Flags: review?(geoff)
Attachment #9019806 -
Flags: review?(geoff)
Comment 10•6 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/97c5ad955dd4 Port bug 1501404, part 7: Move XPCOM registration of nsSyncStreamListener to C-C common/. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 65.0
Updated•6 years ago
|
Attachment #9019806 -
Flags: review?(geoff) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•