1501755 - Preferences / Fonts & Colors / Advanced... is broken in current Nightly

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Jonathan Kew [:jfkthame]]

Attachment: The broken Advanced Font settings dialog

It just produces a small window with Help / Cancel / OK buttons for me on macOS.

People in #developers confirm also broken on Linux.

Comment 1

[Jonathan Kew [:jfkthame]]

Mozregression points to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6e96c7ec0d1187c1b488dd4ba645df9cfd68ec16&tochange=eea979fe8a920693df4859d22fad5c8098a57569.

Of the patches there, bug 1493844 looks the most likely culprit.

Comment 2

[:Paolo Amadini]

Attachment: Bug 1501755 - Restore box element that prevents intermittent layout issues in the Fonts dialog. r=bgrins

Comment 3

[:Paolo Amadini]

This is the weird XBL layout issue that I mentioned before, and I fixed it for the Colors dialog but forgot to restore the "vbox" element in the Fonts dialog. It doesn't seem that other subdialogs are affected.

It may be related to running scripts during "dialog" construction, since having the "script" tag outside of "vbox" makes the intermittent issue reappear. Converting "dialog" to a Custom Element might remove the need for the extra "vbox".

Comment 5

[:Gijs (he/him)]

Why hasn't this landed?

Comment 6

[:Paolo Amadini]

I haven't addressed the last review comment yet.

Comment 7

[:Paolo Amadini]

I've rebased the patch and tested it manually one last time, performance also looks good:

https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=29b35955a321c2211d912431e4b98bc51c82496f&newProject=try&newRevision=eead0f0626c410b9ac698c678f7395cd0ab576f0&framework=1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd2018ed59a
Remove unneeded elements while preventing layout issues in some Preferences dialogs. r=bgrins

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3dd2018ed59a

Comment 10

[Daniel Cicas [:dcicas], Release QA]

I reproduced this issue using Fx 65.0a1, build ID: 20181024221315, on Windows 10 x64, Ubuntu 18.04 and MacOS X 10.13.

I can confirm this issue is verified as fixed, using Fx 65.0b7, build ID: 20181227144402, on Windows 10 x64, Ubuntu 18.04 and MacOS X 10.13.