Closed Bug 1501779 Opened 7 years ago Closed 5 years ago

Use IC entry counters to weight expectedBinaryArithSpecialization

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox65 --- affected

People

(Reporter: mgaudet, Unassigned)

References

Details

IonBuilder uses expectedBinaryArithSpecialization [1] to determine what arithmetic specialization to generate. This is done by looking at the baseline IC stubs [2]. However, the algorithm has no notion of frequency (because until Bug 1494473 determining frequency was impossible). We may be able do a much better job determining the correct arithmetic specialization by weighting with the IC counters we have. [1]: https://searchfox.org/mozilla-central/rev/72b1e834f384a2ffec6eb4ce405fbd4b5e881109/js/src/jit/IonBuilder.cpp#3659 [2]: https://searchfox.org/mozilla-central/rev/72b1e834f384a2ffec6eb4ce405fbd4b5e881109/js/src/jit/BaselineInspector.cpp#684
Depends on: 1501787
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.