Closed
Bug 1501813
Opened 6 years ago
Closed 6 years ago
Remove nsITimerCallback usage from scrollbox
Categories
(Toolkit :: UI Widgets, enhancement, P3)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
Details
Attachments
(1 file)
|
3.09 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
It can just use setTimeout similar to the other caller in scrollbox.
|
Assignee | |
Comment 1•6 years ago
|
||
Sorry, not setTimeout; it can use an nsITimer but just use a helper object.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Assignee: nobody → enndeakin
|
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9019824 -
Flags: review?(dao+bmo)
|
||
Updated•6 years ago
|
Attachment #9019824 -
Flags: review?(dao+bmo) → review+
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1667894f1347 use a helper object rather than have the element implement nsITimerCallback. There is a similar usage elsewhere in the same file. r=dao
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1667894f1347
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•