Closed
Bug 1501869
Opened 6 years ago
Closed 6 years ago
Stop VRService tasks when VR pages are at the background
Categories
(Core :: WebVR, enhancement)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: daoshengmu, Assigned: daoshengmu)
References
Details
Attachments
(2 files, 4 obsolete files)
We notice OpenVR's ::vr::VR_Init will hang VRService thread for a while, so we should avoid call it when it is unnecessary. Besides that, when VR pages have been switched to the background, we still do VRService::Start() and VRService::Stop() in a loop if they are failed to initialize. That makes spawn/kill VRService thread frequently. Therefore, we should only start VR tasks after start doing enumeration. Then, we should check if all VR innerWindow have been moved to the background. if it is true, we will ask VRManager stop doing vr tasks in VRManager.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dmu
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #9019904 -
Attachment is obsolete: true
Assignee | ||
Comment 4•6 years ago
|
||
Updated•6 years ago
|
Attachment #9019905 -
Attachment is obsolete: true
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Updated•6 years ago
|
Attachment #9020233 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9019907 -
Attachment is obsolete: true
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cdb87cbfe882 Part 1: Refine the mechanism for VR tasks. r=kip https://hg.mozilla.org/integration/autoland/rev/56896b0e10d3 Part 2: Stop calling VR tasks when they are at background. r=kip
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/279ffbe01845 Backed out 2 changesets for causing wpt failures on webvr-enabled-by-feature-policy-attribute-redirect-on-load
Comment 9•6 years ago
|
||
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cdebug%2Cweb%2Cplatform%2Ctests%2Cwith%2Ce10s%2Ctest-windows7-32%2Fdebug-web-platform-tests-e10s-9%2Cw-e10s%28wpt9%29&selectedJob=208109054&revision=56896b0e10d3a554e329de778247ff60265c96e3 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=208109054&repo=autoland&lineNumber=61203 Backout link: https://hg.mozilla.org/integration/autoland/rev/279ffbe018451dbee5bec61403801f4265646be8
Flags: needinfo?(dmu)
Comment 10•6 years ago
|
||
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcadaf0b5611 Part 1: Refine the mechanism for VR tasks. r=kip
Comment 11•6 years ago
|
||
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfb96d3d4e0a Part 2: Stop calling VR tasks when they are at background. r=kip
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fcadaf0b5611 https://hg.mozilla.org/mozilla-central/rev/dfb96d3d4e0a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee | ||
Comment 13•6 years ago
|
||
Win 7 try machine will show non-ASCII characters assertion when running a WPT. The root cause is from LoadOvrLib(), we can avoid entering it by making it create D3D 11 objects fail first and don't go to the following functions.
Flags: needinfo?(dmu)
You need to log in
before you can comment on or make changes to this bug.
Description
•