Closed Bug 1501874 Opened 5 years ago Closed 5 years ago

Improve CreateUriList in nsDragService

Categories

(Core :: Widget: Gtk, enhancement)

Product:
Core
Component:
Widget: Gtk
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(1 file)

Remove CreateDataFromPrimitive usage from CreateUriList and clean up surrounding code
46 bytes, text/x-phabricator-request
Details | Review 
I mostly wanted to get rid of nsPrimitiveHelpers::CreateDataFromPrimitive, but this whole function needed some work.

I think the FindCharInReadable usage is correct, but I am still getting used to Gecko string functions. The previous code also handled \r, but all code I could find uses \n like the comment suggests.
Attachment #9019877 - Attachment description: Bug 1501874 - Improve CreateUriList in nsDragService. r?karlt → Remove CreateDataFromPrimitive usage from CreateUriList and clean up surrounding code
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/077264ea997e
Remove CreateDataFromPrimitive usage from CreateUriList and clean up surrounding code r=karlt
https://hg.mozilla.org/mozilla-central/rev/077264ea997e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.