1501879 - test_system_update_fail is totally broken

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Andrew Swan [:aswan]]

The helper function execSystemAddonTest() has a "feature" where it can test that some particular action should fail:
https://searchfox.org/mozilla-central/rev/72b1e834f384a2ffec6eb4ce405fbd4b5e881109/toolkit/mozapps/extensions/test/xpcshell/head_addons.js#1691

But this code catches all exceptions.  In the case of test_system_update_fail.js, it doesn't pass enough arguments to execSystemAddonTest:
https://searchfox.org/mozilla-central/rev/72b1e834f384a2ffec6eb4ce405fbd4b5e881109/toolkit/mozapps/extensions/test/xpcshell/test_system_update_fail.js#181

so we can an exception here:
https://searchfox.org/mozilla-central/rev/72b1e834f384a2ffec6eb4ce405fbd4b5e881109/toolkit/mozapps/extensions/test/xpcshell/head_addons.js#1360

Which makes the test happy thinking that the system addon update failed when in fact we never get around to trying it.  Fixing the immediate error causes the test to fail in a different way that I don't have time to figure out at the moment.

We should both fix the test and fix execSystemAddonTest so that it checks the actual exception that is thrown to ensure that the failure it has caught is the one the test is written to expect.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1501879 fix system update failure tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61e307b93a59
fix system update failure tests r=robwu

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/61e307b93a59