Closed Bug 1501918 Opened 2 years ago Closed 2 years ago
CSS variable tooltip has the wrong size
3.17 MB, image/gif
46 bytes, text/x-phabricator-request
|Details | Review|
7.18 KB, patch
|Details | Diff | Splinter Review|
Other regression from Bug 1472942. STRs: - go to about:newtab - find .outer-wrapper.fixed-to-top (html > body.activity-stream > div#root > div > div.outer-wrapper.fixed-to-top) - in rules view hover on --newtab-search-icon: url(blob:null/5a6ad38a-ffd6-8948-84e7-9fd4fac0f728); you should see the icon in a tooltip - next hover on color: var(--newtab-text-primary-color); ER: The tooltip size should match the content AR: The tooltip size is the same as the one used to preview the image
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Another regression linked to removing setContent API on HTMLTooltip. The initial feedback to remove the method was from me, because we started seeing two ways to set the content of the tooltip (DOM APIs or setContent) and I prefered keeping only one. However the DOM approach still almost forces you to call setContentSize in case your tooltip instance is shared for different content. This is the case for the preview tooltip, which is used for CSS variables, fonts and image previews. Maybe we should revisit the decision to remove this setContent API
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/95fc22009760 Restore tooltip size when updating Variable and BrokenImage content;r=pbro
Is this something you might want to uplift to 64 beta?
Yes, it would be nice to have it on beta! [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1472942 User impact if declined: CSS variables tooltips in the DevTools inspector might have an incorrect size. Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: No Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Small javascipt fix, covered in automation String changes made/needed: none
I reproduced this issue with Fx 65.0a1 (20181024221315) on Windows 10 x64. The tooltip size is matching the content as expected with the latest Nightly 65.0a1 (20181026100128) on Windows 10 x64, macOS 10.13 and Ubuntu 18.06 x64.
Comment on attachment 9020269 [details] [diff] [review] bug-1501918-beta.patch Fixes incorrect sizing of CSS variables tooltips in the DevTools inspector. Approved for 64.0b5.
Attachment #9020269 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This issue is also fixed with the latest Fx Beta 64.0b5 (20181029164536) on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.
You need to log in before you can comment on or make changes to this bug.