Closed Bug 1501944 Opened 2 years ago Closed 2 years ago

[Wayland] Enable wayland target builds on Gtk 3.10

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1501944 - Enable to build wayland target on Gtk 3.10, r=jhorak
47 bytes, text/x-phabricator-request
Details | Review 
In order to build Wayland target at Mozilla infrastructure we need to make cairo-gtk3-wayland target compatible with Gtk 3.10.
Assignee: nobody → stransky
from try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3337b8f7b4f0c409c5150c7415dfd3c5566b2160&selectedJob=207769916

Looks like we're missing gtk+-wayland-3.0 .pc files at try:

[task 2018-10-25T13:15:57.779Z] 13:15:57     INFO -  checking for gtk+-wayland-3.0 >= 3.10... no
[task 2018-10-25T13:15:57.779Z] 13:15:57     INFO -  ERROR: Package gtk+-wayland-3.0 was not found in the pkg-config search path.
[task 2018-10-25T13:15:57.779Z] 13:15:57     INFO -  ERROR: Perhaps you should add the directory containing `gtk+-wayland-3.0.pc'
[task 2018-10-25T13:15:57.780Z] 13:15:57     INFO -  ERROR: to the PKG_CONFIG_PATH environment variable
[task 2018-10-25T13:15:57.780Z] 13:15:57     INFO -  ERROR: No package 'gtk+-wayland-3.0' found

I'll look how is this distributed on such old systems, it's present by default on Ubuntu 16.04.
Attached patch wip-3.10.patch (obsolete) — — Splinter Review 
WIP, builds fine on Ubuntu 16.04, fails on try.
Mike, looks like the gtk3 packages which are installed on try are not built with --enable-wayland-backend so the gtk+-wayland-3.0.pc is missing. Can that be adjusted? Thanks.
Flags: needinfo?(mh+mozilla)
We don't _build_ on Ubuntu 16.04. We _test_ on Ubuntu 16.04. We build on Debian Wheezy + custom built Gtk _3.4_. It seems reasonable to bump that to 3.10, but we haven't made the choice yet. Please make this about allowing to build against Gtk 3.10.
Flags: needinfo?(mh+mozilla)
Blocks: 1503592
Attachment #9020005 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22770cb58170
Enable to build wayland target on Gtk 3.10, r=jhorak
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/22770cb58170
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.