Remove global Content Blocking toggle in the main menu and about:preferences

RESOLVED FIXED in Firefox 65

Status

()

P1
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(Whiteboard: [privacy65])

Attachments

(2 attachments)

(Assignee)

Description

5 months ago
The updated design spec switches from having a global toggle for content blocking to "Standard", "Strict" and "Custom" modes (https://mozilla.invisionapp.com/share/RHORBWDNX4W#/screens).

We also want to remove the browser.contentblocking.enabled pref.

Thus, we'd like to remove the global toggles again.
(Assignee)

Updated

5 months ago
Blocks: 1501978
(Assignee)

Updated

5 months ago
Blocks: 1501980
(Assignee)

Updated

5 months ago
Blocks: 1501985
(Assignee)

Updated

5 months ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P2 → P1
(Assignee)

Comment 1

5 months ago
This patch also removes some of the other handling of browser.contentblocking.enabled
in about:preferences, such as disabling the cookies and site data section.
(Assignee)

Comment 3

5 months ago
Ah, I didn't realize that bug 1502076 had landed on central already. I'll need to rebase on that.

Comment 4

5 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74a560ef3b51
Remove global Content Blocking toggle in about:preferences. r=flod,Ehsan
https://hg.mozilla.org/integration/autoland/rev/e1404c73b666
Remove global Content Blocking toggle in the main menu. r=Ehsan

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/74a560ef3b51
https://hg.mozilla.org/mozilla-central/rev/e1404c73b666
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
We gain some perf boost! \0/

== Change summary for alert #17179 (as of Fri, 26 Oct 2018 15:17:05 GMT) ==

Improvements:

  5%  about_preferences_basic windows7-32 opt e10s stylo         136.09 -> 129.60
  3%  about_preferences_basic windows10-64-qr opt e10s stylo     138.72 -> 134.60
  3%  about_preferences_basic windows10-64 opt e10s stylo        137.55 -> 134.03
  2%  about_preferences_basic linux64-qr opt e10s stylo          148.15 -> 145.27
  2%  about_preferences_basic osx-10-10 opt e10s stylo           202.44 -> 198.70

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17179
You need to log in before you can comment on or make changes to this bug.