1501984 - Use the React profiler to look for quick performance wins

Status: NEW

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Ed Morley [:emorley]]

https://reactjs.org/blog/2018/09/10/introducing-the-react-profiler.html

Notably it might help us spot cases where we should be using PureComponent or the new function equivalent, `React.memo()`:
https://reactjs.org/blog/2018/10/23/react-v-16-6.html#reactmemo

Comment 1

[Ed Morley [:emorley]]

react-devtools currently makes the main job-view pages pretty unresponsive unless filtered down to only viewing one push.

I've filed:
https://github.com/facebook/react-devtools/issues/1200#issuecomment-437346433

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4353

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3520515e2ab8f27ba4cf8141414fbfcd42ca8f57
Bug 1501984 - Fix too much re-rendering in App for url changes (#4353)

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4444

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4445

Comment 6

[Ed Morley [:emorley]]

(In reply to Ed Morley [:emorley] from comment #1)

react-devtools currently makes the main job-view pages pretty unresponsive
unless filtered down to only viewing one push.

I've filed:
https://github.com/facebook/react-devtools/issues/1200#issuecomment-437346433

The author of react-devtools replied to that issue with a few suggestions fwiw :-)

Comment 7

[Cameron Dawson [:camd]]

I'm not going to do further work on this any time soon.