Closed Bug 1502002 Opened 2 years ago Closed 2 years ago
Simplify the flex item outline and sizing properties components now that 1498273 landed
46 bytes, text/x-phabricator-request
|Details | Review|
Bug 1498273 improves the getAsFlexContainer platform API so that, now, all flex items also come with a clampState that tells us whether the item was clamped to min, clamped to max or unclamped. We can make use of this extra information to simplify quite a lot the logic in 2 of our components: FlexItemSizingOutline FlexItemSizingProperties
A note about backward compatibility is required for this: The actor changes for the flex item sizing information landed in Firefox 64. Now, for this bug, we'll need to change them a little bit (basically add the clampState to each FlexItemActor). So, potentially this is a non-backward compatible change. We usually deal with those by feature-detecting in the UI of DevTools and falling back to some other code path when necessary. Now, for this particular change, I don't think this is needed. The reason is that the flex item tool is not riding the trains to release with 64. It's only enabled in nightly and devedition 64 as an early preview to get feedback. So I don't think we need to support cases where a DevTools UI 65 would connect to a DevTools server 64 and expect the flex item info to work, given that we will only be announcing the tool with 65. At best, we should make sure it doesn't just explodes.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/aea0e7fadf7d Start using the getAsFlexContainer API's clampState value to simplify devtools; r=gl
Backed out changeset aea0e7fadf7d (bug 1502002)for ES lint failure on components/FlexItemSizingOutline.js "CLOSED TREE" Backout revision: https://hg.mozilla.org/integration/autoland/rev/2db84dbb7f99acbe326b372d03be97620b27fba0 Backout push:https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=207960712&revision=2db84dbb7f99acbe326b372d03be97620b27fba0 Failed push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=207960712&revision=aea0e7fadf7db4948b4bf8a818902ed79cbdab7d Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=207960712&repo=autoland :pbro Could you please take a look?
Sorry about that. I fixed these eslint problems locally, and pushed again.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c7d1909cd2ae Start using the getAsFlexContainer API's clampState value to simplify devtools; r=gl
You need to log in before you can comment on or make changes to this bug.