1502023 - canvas.js::clearRect doesn't work with transformation matrices

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Broken.gif

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Fixed.gif

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We call the following from flexbox.js.

clearRect(this.ctx, 8, 2, 81, 113, this.currentMatrix);

This **should** clear a section of the canvas taking any transforms into account.

Because of the way canvas.js::clearRect() is written it **always** draws an upright rectangle regardless of any transforms (see attachment 9019998 [details]).

With the attached path this issue is fixed (see attachment 9019999 [details]).

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1502023 - canvas.js::clearRect doesn't work with transformation matrices

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cdaa33486f4
canvas.js::clearRect doesn't work with transformation matrices r=gl

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8cdaa33486f4