Closed Bug 1502031 Opened 6 years ago Closed 5 years ago

[wpt-sync] Sync PR 13720 - New value 'break-spaces' for the white-space property

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 13720 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13720
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:
>  New value 'break-spaces' for the white-space property
>  
>  Finally the CSS WG decided [1] to move back the 'break-spaces' value to
>  the 'white-space' property. This makes the parsing logic easier than
>  the previous approach of using the 'overflow-wrap' property.
>  
>  This new value prevents the white-space sequence to collapse and gives
>  breaking opportunities after every preserved white-space.
>  
>  https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces
>  
>  Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the
>  end of a line cannot be hung or visually collapsed, since we want them
>  to be preserved and broken.
>  
>  [1] https://github.com/w3c/csswg-drafts/pull/2841
>  
>  Bug: 767634
>  Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67
>  Reviewed-on: https://chromium-review.googlesource.com/1136543
>  WPT-Export-Revision: 76586dc570eebc0d0f6337a0e1163976bc614b19
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 14 tests
PASS   : 3
FAIL   : 11

New tests that have failures or other problems:
/css/css-text/overflow-wrap/overflow-wrap-break-word-006.html: FAIL
/css/css-text/white-space/break-spaces-004.html: FAIL
/css/css-text/white-space/break-spaces-005.html: FAIL
/css/css-text/white-space/break-spaces-006.html: FAIL
/css/css-text/white-space/break-spaces-007.html: FAIL
/css/css-text/white-space/break-spaces-008.html: FAIL
/css/css-text/white-space/pre-wrap-016.html: FAIL
/css/css-text/word-break/word-break-break-all-012.html: FAIL
/css/css-text/word-break/word-break-break-all-013.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a5612bfa515
[wpt PR 13720] - [css-text] New value 'break-spaces' for the white-space property, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8989376bd9f
[wpt PR 13720] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3fbc71412c5
[wpt PR 13720] - [css-text] New value 'break-spaces' for the white-space property, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/42ff086f8f47
[wpt PR 13720] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d3fbc71412c5
https://hg.mozilla.org/mozilla-central/rev/42ff086f8f47

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.