Closed
Bug 1502053
Opened 6 years ago
Closed 6 years ago
Overhaul GeckoRuntimeSettings prefs usage
Categories
(GeckoView :: General, enhancement, P2)
Tracking
(geckoview64 wontfix, firefox64 wontfix, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: snorp, Assigned: snorp)
Details
Attachments
(4 files)
There are a couple of big problems with how we use prefs from GeckoRuntimeSettings: 1) Prefs are set persistently, which is not ideal since the source of truth for these values should always by the value in GeckoRuntimeSettings. Also... 2) Because of 1), Gecko can read a pref from the disk before we're able to set it. This races a bunch of startup code in Gecko that may only read the pref once.
Updated•6 years ago
|
Assignee: nobody → snorp
Priority: -- → P2
Assignee | ||
Comment 1•6 years ago
|
||
We don't want to store a persistent value for these prefs because the value is managed by the app via GeckoRuntimeSettings. Using the default branch is the best way to do this currently, though it does mean the value could be shadowed by a user pref. To combat this we also reset any of the user prefs that are managed via GeckoRuntimeSettings.
Assignee | ||
Comment 2•6 years ago
|
||
This is easier to manage than a billion arguments. Depends on D9818
Assignee | ||
Comment 3•6 years ago
|
||
This will be used by GeckoView to set initial pref values that would normally come from user.js on desktop. Depends on D9819
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D9820
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e22d0944e7 Use default branch for prefs in GeckoRuntimeSettings r=esawin https://hg.mozilla.org/integration/mozilla-inbound/rev/77093f3ce69f Use GeckoThread.InitInfo to pass args to GeckoThread.init() r=esawin https://hg.mozilla.org/integration/mozilla-inbound/rev/d322d3458bf3 Parse default prefs from MOZ_DEFAULT_PREFS env var r=njn https://hg.mozilla.org/integration/mozilla-inbound/rev/7131a22bb5e7 Send initial GeckoRuntimeSettings prefs via environment variable r=esawin
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d8e22d0944e7 https://hg.mozilla.org/mozilla-central/rev/77093f3ce69f https://hg.mozilla.org/mozilla-central/rev/d322d3458bf3 https://hg.mozilla.org/mozilla-central/rev/7131a22bb5e7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 7•6 years ago
|
||
64=wontfix because we don't need to uplift this fix for Focus 8.0's GV 64 beta test
status-firefox64:
--- → wontfix
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Updated•5 years ago
|
Version: Firefox 59 → 59 Branch
Updated•5 years ago
|
Target Milestone: Firefox 65 → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•