1502053 - Overhaul GeckoRuntimeSettings prefs usage

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

There are a couple of big problems with how we use prefs from GeckoRuntimeSettings:

1) Prefs are set persistently, which is not ideal since the source of truth for these values should always by the value in GeckoRuntimeSettings. Also...

2) Because of 1), Gecko can read a pref from the disk before we're able to set it. This races a bunch of startup code in Gecko that may only read the pref once.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1502053 - Use default branch for prefs in GeckoRuntimeSettings r?esawin

We don't want to store a persistent value for these prefs because
the value is managed by the app via GeckoRuntimeSettings. Using
the default branch is the best way to do this currently, though
it does mean the value could be shadowed by a user pref. To combat
this we also reset any of the user prefs that are managed
via GeckoRuntimeSettings.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1502053 - Use GeckoThread.InitInfo to pass args to GeckoThread.init() r?esawin

This is easier to manage than a billion arguments.

Depends on D9818

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1502053 - Parse default prefs from MOZ_DEFAULT_PREFS env var r?njn

This will be used by GeckoView to set initial pref values that would
normally come from user.js on desktop.

Depends on D9819

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1502053 - Send initial GeckoRuntimeSettings prefs via environment variable r?esawin

Depends on D9820

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e22d0944e7
Use default branch for prefs in GeckoRuntimeSettings r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/77093f3ce69f
Use GeckoThread.InitInfo to pass args to GeckoThread.init() r=esawin
https://hg.mozilla.org/integration/mozilla-inbound/rev/d322d3458bf3
Parse default prefs from MOZ_DEFAULT_PREFS env var r=njn
https://hg.mozilla.org/integration/mozilla-inbound/rev/7131a22bb5e7
Send initial GeckoRuntimeSettings prefs via environment variable r=esawin

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d8e22d0944e7
https://hg.mozilla.org/mozilla-central/rev/77093f3ce69f
https://hg.mozilla.org/mozilla-central/rev/d322d3458bf3
https://hg.mozilla.org/mozilla-central/rev/7131a22bb5e7

Comment 7

[Chris Peterson [:cpeterson]]

64=wontfix because we don't need to uplift this fix for Focus 8.0's GV 64 beta test

Comment 8

[Chris Peterson [:cpeterson]]

status-geckoview64=wontfix