1502072 - javascript url bookmarks don't run if opened in new tab

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[omgitsraven]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Make a bookmark to a javascript: url, then right-click it and do "open in a new tab".


Actual results:

A blank tab opens, with the javascript in its address bar, but the script does not run.


Expected results:

It should behave the same as it does if the bookmark were just left-clicked on, i.e. the script should run.

Comment 1

[Matthias Versen [:Matti]]

Do you mean something like https://support.mozilla.org/de/questions/1009266 ?

Comment 2

[omgitsraven]

The opposite of that, actually -- they were saying that their bookmarklet would ONLY work if you do 'open in new tab' in the context menu. I'm saying it only works if you DON'T.

Comment 3

[Matthias Versen [:Matti]]

Please ignore my last comment, that was an old bug but this is a recent regression.


2018-10-26T01:28:44: DEBUG : Found commit message:
Bug 1466801 - Flipping disallowInheritPrincipal to be allow. r=ckerschb r=gijs

2018-10-26T01:28:44: DEBUG : Did not find a branch, checking all integration branches
2018-10-26T01:28:44: INFO : The bisection is done.


This looks like a intentional change

Comment 4

[omgitsraven]

I definitely saw the recent stuff about changing what permissions javascript urls have, and I assume that it came about as a *result* of that, but I'm not sure whether this particular aspect of it could be intentional? What would the rationale be behind "running a bookmarklet in an existing tab is fine, running it in a new one isn't"? (If it were a security concern, I'd expect it to be the other way around…)

Comment 5

[Jonathan Kingston [:jkt] he/him]

I'm pretty sure this is a duplicate of Bug 1484741 which isn't in 63 but is riding the trains instead.

Comment 6

[:Gijs (he/him)]

(In reply to Jonathan Kingston [:jkt] from comment #5)
> I'm pretty sure this is a duplicate of Bug 1484741 which isn't in 63 but is
> riding the trains instead.

I thought that, but the STR in this bug involve the context menu on bookmarks, and your fix in that bug only touches urlbarbindings.xml, so I think a separate fix would be required. Did the context menu case get fixed elsewhere?

Comment 7

[omgitsraven]

Also, just to be as specific as possible, I might as well mention, it also doesn't work when middle-clicking the bookmark (which does the same thing as 'open in new tab').

Comment 8

[Matthias Versen [:Matti]]

I have tested this bug with the latest nightly before confirming this report and this is not fixed by bug 1484641.

Middle mouse button click or context menu->open in new tab doesn't work after the checkin from bug 1466801
It works if you use the context menu to open the bookmarklet in a new window instead of a new tab.

Comment 9

[:Gijs (he/him)]

This is a regression and ideally we should fix for 64, though js: bookmarks are a bit of an edgecase and opening them in separate tabs even more so. Going to move to Fx::Bookmarks and Marco & co can decide on priority.

:jkt, any idea what's going on here and why we didn't catch this before release?

Comment 10

[Jonathan Kingston [:jkt] he/him]

Pretty sure I know how to fix this, I'll take a look later.

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Jonathan, do you plans to work on fixing this bug for 67 or should we move that bug to the backlog (P3)? Thanks

Comment 12

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1502072 - Removing restriction of opening javascript places into new tabs. r?Gijs

Comment 13

[Jonathan Kingston [:jkt] he/him]

:gijs sorry for the delay here. I think we should just permit this to all 'aWhere' targets. I think it's safe to uplift too.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b14084271877
Removing restriction of opening javascript places into new tabs. r=Gijs

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b14084271877