47 bytes, text/x-phabricator-request
|Details | Review|
The opposite of that, actually -- they were saying that their bookmarklet would ONLY work if you do 'open in new tab' in the context menu. I'm saying it only works if you DON'T.
Please ignore my last comment, that was an old bug but this is a recent regression. 2018-10-26T01:28:44: DEBUG : Found commit message: Bug 1466801 - Flipping disallowInheritPrincipal to be allow. r=ckerschb r=gijs 2018-10-26T01:28:44: DEBUG : Did not find a branch, checking all integration branches 2018-10-26T01:28:44: INFO : The bisection is done. This looks like a intentional change
I'm pretty sure this is a duplicate of Bug 1484741 which isn't in 63 but is riding the trains instead.
(In reply to Jonathan Kingston [:jkt] from comment #5) > I'm pretty sure this is a duplicate of Bug 1484741 which isn't in 63 but is > riding the trains instead. I thought that, but the STR in this bug involve the context menu on bookmarks, and your fix in that bug only touches urlbarbindings.xml, so I think a separate fix would be required. Did the context menu case get fixed elsewhere?
Also, just to be as specific as possible, I might as well mention, it also doesn't work when middle-clicking the bookmark (which does the same thing as 'open in new tab').
I have tested this bug with the latest nightly before confirming this report and this is not fixed by bug 1484641. Middle mouse button click or context menu->open in new tab doesn't work after the checkin from bug 1466801 It works if you use the context menu to open the bookmarklet in a new window instead of a new tab.
This is a regression and ideally we should fix for 64, though js: bookmarks are a bit of an edgecase and opening them in separate tabs even more so. Going to move to Fx::Bookmarks and Marco & co can decide on priority. :jkt, any idea what's going on here and why we didn't catch this before release?
Pretty sure I know how to fix this, I'll take a look later.
Assignee: nobody → jkt
Flags: needinfo?(jkt) → needinfo?(gijskruitbosch+bugs)
You need to log in before you can comment on or make changes to this bug.