Closed Bug 1502076 Opened 5 years ago Closed 5 years ago

Remove the fastblock UI

Categories

(Firefox :: Protections UI, enhancement)

Product:
Firefox
Component:
Protections UI
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

(Whiteboard: [privacy65])

Attachments

(2 files)

Bug 1502076 - Part 1: Remove the fastblock UI from Preferences
46 bytes, text/x-phabricator-request
Details | Review
Bug 1502076 - Part 2: Remove the fastblock UI from the Control Centre
46 bytes, text/x-phabricator-request
Details | Review 
      No description provided.
Blocks: cookierestrictions
Whiteboard: [privacy65]
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc41d57ddd83
Part 1: Remove the fastblock UI from Preferences r=flod,johannh
https://hg.mozilla.org/integration/autoland/rev/4579afb8b513
Part 2: Remove the fastblock UI from the Control Centre r=johannh
https://hg.mozilla.org/mozilla-central/rev/fc41d57ddd83
https://hg.mozilla.org/mozilla-central/rev/4579afb8b513
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Why got this removed?
Flags: needinfo?(ehsan)
See https://blog.mozilla.org/futurereleases/2018/10/23/the-path-to-enhanced-tracking-protection/ (the section under "Sometimes plans change"...)
Flags: needinfo?(ehsan)
I tested this and found out that the UI is deleted from Preferences and Control Centre also. There is only one question before I can mark this as Verified. 

I saw that browser.fastblock.enabled, browser.fastblock.limit and browser.fastblock.timeout are still available in the about:config page. Even if I set browser.fastblock.enabled to true, the UI will not appear. Is it OK that these preferences are not deleted from about:config even if the UI will not appear?
Flags: needinfo?(ehsan)
(In reply to David Olah from comment #7)
> I tested this and found out that the UI is deleted from Preferences and
> Control Centre also. There is only one question before I can mark this as
> Verified. 
> 
> I saw that browser.fastblock.enabled, browser.fastblock.limit and
> browser.fastblock.timeout are still available in the about:config page. Even
> if I set browser.fastblock.enabled to true, the UI will not appear. Is it OK
> that these preferences are not deleted from about:config even if the UI will
> not appear?

Yes, that's intentional.  The backend code for this feature still exists and is functional, it just won't do anything at the UI level.
Flags: needinfo?(ehsan)
You need to log in before you can comment on or make changes to this bug.