150208 - Download status doesn't stop

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect, P4)

Description

[Neil Lee [:neilio]]

The nice, aqua status bar that slowly fills in the downloads status window
doesn't stop "animating" when the download has actually completed. I believe
this is new to 0.30 - I seem to remember it stopping in earlier builds.

Comment 1

[Chris Petersen]

I see this problem only after transfering a file using FTP protocol. Attaching a
test case that has links for both HTTP and FTP. Progress indicator doesn't stop
animating after ftp transfer is completed. As a comparsion, the animation stops
after HTTP transfer is done.

Comment 2

[Chris Petersen]

Attachment: Sample test case that has links using HTTP and FTP

This test case contains links that either HTTP or FTP to transfer file. I have
noticed that the download progress animation does stop after has been
completely transfered using FTP.

Comment 3

[saari (gone)]

->pinkerton

Comment 4

[David Haas (gone, not reading mail)]

I checked out the sample case. All this code is in ProgressDlgController.mm

Using the FTP link, in nsDownloadListener::OnProgressChange, aMaxTotalProgress
value is coming back (for this file) as 10973106.

Unfortunately, nsDownloadListener::OnStatusChange is reporting that we're all
done with the download when aCurTotalProgress (from OnProgressChange) is at
10956168.

So, the progress bar keeps animating itself because it's aCurTotalProgress never
quite equals aMaxTotalProgress.  I don't know if there's a screwup in the FTP
file download size calc, or if somehow for FTP downloads OnStatusChange gets
called as "done" before OnProgressChange gets called with a report of the last
few bytes being download, or something else entirely.

Anyway, part of the newest patch for bug #143093 makes sure the progress bar
thinks it's done when the download is finished, so you don't see this behavior.  

Comment 5

[Mike Pinkerton (not reading bugmail)]

this appears fixed with the other patch i landed this morning (143093)

Comment 6

[Chris Petersen]

Verified using the 2002-06-28-05 NB.