1502088 - Alerts subtest links should point to comparison corresponding to their original summary in case they are reassigned

Status: VERIFIED FIXED

(Tree Management :: Perfherder, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Visit https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-inbound&originalRevision=c19f84cb5fcbf896171350432d4476ba27d11d15&newProject=mozilla-inbound&newRevision=72e7ef77480d0845ceabb5d3747a5523db6bda9d&originalSignature=54aafe1d20a4668f0357f6f4e67d9de5db4d76a6&newSignature=54aafe1d20a4668f0357f6f4e67d9de5db4d76a6&framework=1
2. Watch the cute cats

ER:

Cute cats should eventually give way to a comparison view between two revisions for the tps test subtests.

AR:

Cute cats forever, and "TypeError: W is undefined; can't access it's "undefined" property" in my browser console.

Comment 1

[William Lachance (:wlach)]

Ok this is a weird one, part of the problem is bug 1502018 which :jmaher just reported, but fixing that just gives a completely empty set of results. There are no subtest results for either revision on the platform requests (linux64)

:mconley mentioned that the subtest comparison came from this result:

https://treeherder.mozilla.org/perf.html#/alerts?id=16593

But if you look at the tps linux results there, the original summary with that alert is actually this one:

https://treeherder.mozilla.org/perf.html#/alerts?id=16601

If I click compare on that one, I get the page as expected.

In the case that an alert is reassigned, we should probably use the original summary's revision metadata for the comparison.

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b00f5473860b179048873474cd9856bfc25c227e
Bug 1502088 - Workaround for case where no data for subtest comparison

We used to assume that there would always be data for a subtest comparison.
Not always true, depending on the parameters! This doesn't look very good,
but is better than endless cats and a console error.

Comment 3

[Ionuț Goldan [:igoldan]]

:mconley can you confirm this issue got fixed? I'm not able to use that URL, because we've deprecated the use of hashes for the signature params.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Yes, this issue got fixed. Thanks!