Remove nodeAnnotationChanged
Categories
(Toolkit :: Places, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: standard8, Assigned: mak, Mentored)
References
Details
(Keywords: perf, Whiteboard: [fxsearch][lang=js|cpp])
Attachments
(1 file)
Once bug 1501811 lands we no longer need nodeAnnotationChanged as that was basically only being used for livemarks. We should also no longer need to send onItemChanged for annotations. There's possibly one use case for Sync here that we should check, but we believe we should be ok to remove that as well.
|
Assignee | |
Updated•6 years ago
|
|
Reporter | |
Comment 1•5 years ago
|
||
I've split the onItemChanged changes out to a new bug - bug 1519840 - and described them there. As this bug was, it was really implementing two things that weren't quite matching.
Assigning to Alex as he's said he'll work on it.
|
|
Reporter | |
Comment 2•5 years ago
|
||
As far as I know, Alex isn't working on this at the moment.
|
|
Reporter | |
Comment 3•5 years ago
|
||
If you're interested in working on this bug, it affects both c++ and javascript, so you'll a full build rather than an artefact one. Here's a link to existing code locations:
https://searchfox.org/mozilla-central/search?q=nodeAnnotationChanged&case=false®exp=false&path=
Most of the changes should be simple code removals, but check to see if there's any other items that could be removed (although, don't change the function signature for OnItemChanged at this time.
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/7b70a9ccdc17 Remove obsolete nodeAnnotationChanged. r=Standard8
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•