1502147 - Make pushes collapsible to free memory on completed pushes, when there still are running jobs below

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement)

Description

[Bogdan Tara[:bogdan_tara | bogdant]]

I think this would make the sheriffs lives easier:

Add a toggle to collapse a push, so that just the push date, e-mail, mercurial link and commit message are visible.

Ideally, the collapsed push would be discarded to free some memory on the sheriffs computers.

:camd is this worth a try?

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4242

Comment 2

[Ed Morley [:emorley]]

I think the issue this is wanting to resolve might be better fixed by bug 1107667 instead?

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Attachment: th_improvement_suggestion.png

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Attached a graphic sketch-up of my suggestion.
The idea is to free as much memory as possible and some screen space in cases when there still are running jobs below pushes with all tests done.
This happens quite often on autoland and inbound.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

:emorley there are cases when a fixed page size would not help at all.
We already can select the top and bottom pushes - this can make TH faster when we're looking at 3-4 pushes.

Comment 6

[Ed Morley [:emorley]]

This still feels like a premature optimization - we should first start by improving actual+perceived performance and memory usage, then after resort to these approaches if that still isn't enough.

In addition, hiding pushes retrospectively doesn't make the initial load faster - the pushes still have to load and then later manually be hidden one at a time. This seems like very manual-busywork for small performance gain.

I do agree that the performance on mozilla-central (where pushes have thousands and thousands of jobs) is particularly bad at the moment. Perhaps a better solution would be to set a limit on max jobs per push, and if exceeded, then hide passing builds by default or similar? Or default the page size to 5 not 10?

Comment 7

[Ed Morley [:emorley]]

One approach to improving performance might be only rendering the pushes that are in the current view-port. I've filed bug 1506062 for this :-)

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

If a push can be collapsed and kept collapsed on refresh/new tab, it could be helpful.
Bug 1506062 makes more sense. :)

Comment 9

[Cameron Dawson [:camd]]

While this certainly isn't the whole solution to the memory/performance issues, I still feel this is a worthwhile feature.  This impl is persisted in the URL for sharing.  It can be used to reduce noise in some of those circumstances.  

I'm really curious, though, how things like the package mentioned in bug 1506062 will work.  That could be really cool.

Tbh, though, I suspect there's something with how the pushes are stored and used with a Context.  Not certain yet, but I'm hunting.

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ef46ad29190637bffce4b4c53fcd88314f206240
Bug 1502147 - Add ability to collapse pushes (#4242)

Comment 11

[Kartikaya Gupta (email:[e-mail])]

This makes me so happy, thank you!