1502176 - Replace assertThrows with assertThrowsInstanceOf in js/src/tests/non262 when Error type is tested

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[André Bargull [:anba]]

This query [1] shows multiple callers to |assertThrows| [2] which should actually be |assertThrowsInstanceOf| [3], because they pass an explicit Error type. 


[1] https://searchfox.org/mozilla-central/search?q=assertThrows(&case=true&regexp=false&path=js%2Fsrc%2Ftests%2Fnon262
[2] https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/js/src/tests/shell.js#148
[3] https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/js/src/tests/shell.js#160

Comment 1

[Jason Orendorff [:jorendorff]]

Good catch.

Comment 2

[Ashley Hauck [:khyperia]]

Attachment: Bug 1502176 - Fix broken assertThrows tests.

Comment 3

[Ashley Hauck [:khyperia]]

Attachment: Bug 1502176 - Change assertThrows with type to assertThrowsInstanceOf.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b5217daca7
Fix broken assertThrows tests. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/5f04783422b4
Change assertThrows with type to assertThrowsInstanceOf. r=jorendorff

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/31b5217daca7
https://hg.mozilla.org/mozilla-central/rev/5f04783422b4