Closed Bug 1502266 Opened Last year Closed Last year

Activity Stream falsely assumes @mozilla.org/updates/update-checker;1 is always present

Categories

(Firefox :: New Tab Page, defect, P1)

57 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 65
Iteration:
65.1 - Nov 2
Tracking Status
firefox65 --- fixed

People

(Reporter: kmag, Assigned: andreio)

References

Details

Attachments

(1 file)

When running tests in builds with the update checker disabled, all browser tests now fail with:

A promise chain failed to handle a rejection: Cc['@mozilla.org/updates/update-checker;1'] is undefined; can't access its "createInstance" property - stack: CheckBrowserNeedsUpdate@resource://activity-stream/lib/ASRouterTargeting.jsm:66:9

Browser code can't rely on the update check service always being present, since there are compile-time options to disable it.
Blocks: 1492853
Component: New Tab Page → Activity Streams: Newtab
Assignee: nobody → andrei.br92
Iteration: --- → 65.1 (Nov 2)
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/db2f232e9cf65384df7f2c97aafcfffbcd531106
Fix Bug 1502266 - Verify that Update Checker is available before creating an instance (#4532)
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Blocks: 1503989
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.