1502312 - PlacesUtils.validatePageInfo isn't setting requiredIf for url/guid properly.

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P2)

Description

[Mark Banner (:standard8)]

In PlacesUtils.validatePageInfo we currently have:

```
  validatePageInfo(pageInfo, validateVisits = true) {
    return this.validateItemProperties("PageInfo", PAGEINFO_VALIDATORS, pageInfo,
      { url: { requiredIf: b => { typeof b.guid != "string"; } },
        guid: { requiredIf: b => { typeof b.url != "string"; } },
        visits: { requiredIf: b => validateVisits  },
      });
  },
```

I just realised this is wrong, as the curly braces around the typeof mean that it is treated as a function body, and hence would require a return statement to return the value. So they'd never be set as required.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1502312 PlacesUtils.validatePageInfo isn't setting requiredIf for url/guid properly. r?mak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2ea2c762c5d
PlacesUtils.validatePageInfo isn't setting requiredIf for url/guid properly. r=mak

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f2ea2c762c5d