1502361 - Remove Content Blocking toggle from about:privatebrowsing

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

We are redoing the way content blocking is presented in product (with different "modes") and the toggle on about:privatebrowsing doesn't really fit anymore. It was always a bit misleading since we grouped TP under content blocking.

The new minimum/standard setting will be having TP always-on in private browsing, and users who don't want it will need to opt out per-site by adding exceptions in the control center.

Comment 1

[(no longer active)]

(In reply to Johann Hofmann [:johannh] from comment #0)
> The new minimum/standard setting will be having TP always-on in private
> browsing, and users who don't want it will need to opt out per-site by
> adding exceptions in the control center.

Do we need some copy for this?  Or are we just removing the row with the icon and the toggle and leaving it at that?

Comment 2

[Johann Hofmann [:johannh]]

(In reply to :Ehsan Akhgari from comment #1)
> (In reply to Johann Hofmann [:johannh] from comment #0)
> > The new minimum/standard setting will be having TP always-on in private
> > browsing, and users who don't want it will need to opt out per-site by
> > adding exceptions in the control center.
> 
> Do we need some copy for this?  Or are we just removing the row with the
> icon and the toggle and leaving it at that?

We should probably ask Bryan and Betsy what they had in mind for about:privatebrowsing. The AS team is currently working on a private search option for that page so the design might change significantly anyway.

I also filed bug 1502374 to ensure that we offer users a way to restore their settings to default when they flipped the toggle to false in the past.

Comment 3

[(no longer active)]

Note: this line was added for the sake of about:privatebrowsing, and we may be able to remove it when this bug is fixed: https://searchfox.org/mozilla-central/rev/5b3b6b8fd9f90087f618c20382e631451136ed2b/toolkit/modules/AsyncPrefs.jsm#23

Comment 4

[(no longer active)]

(In reply to :Ehsan Akhgari from comment #3)
> Note: this line was added for the sake of about:privatebrowsing, and we may
> be able to remove it when this bug is fixed:
> https://searchfox.org/mozilla-central/rev/
> 5b3b6b8fd9f90087f618c20382e631451136ed2b/toolkit/modules/AsyncPrefs.jsm#23

Also https://searchfox.org/mozilla-central/rev/5b3b6b8fd9f90087f618c20382e631451136ed2b/toolkit/components/remotepagemanager/MessagePort.jsm#29

Comment 5

[Johann Hofmann [:johannh]]

Attachment: Bug 1502361 - Remove Content Blocking toggle from about:privatebrowsing. r=Ehsan

This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out as per Johann`s request.

Push link: https://hg.mozilla.org/integration/autoland/rev/d8813fdff117437566fe7a7e32820abcad67058c
Backout link: https://hg.mozilla.org/integration/autoland/rev/5cb1a7a1be68026e3cb6ef2564c2aed880ac2d2e

Comment 7

[Johann Hofmann [:johannh]]

Yup, thanks, had a small test failure on try, unfortunately. Will re-land now...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd9666a8a5b
Remove Content Blocking toggle from about:privatebrowsing. r=Ehsan

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8bd9666a8a5b

Comment 10

[David Olah]

I verified this issue on Nightly 65.0a1 (2018-11-07).