Remove Content Blocking toggle from about:privatebrowsing

VERIFIED FIXED in Firefox 65

Status

()

P1
normal
VERIFIED FIXED
5 months ago
5 months ago

People

(Reporter: johannh, Assigned: johannh, NeedInfo)

Tracking

(Blocks: 2 bugs)

unspecified
Firefox 65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 verified)

Details

(Whiteboard: [privacy65])

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
We are redoing the way content blocking is presented in product (with different "modes") and the toggle on about:privatebrowsing doesn't really fit anymore. It was always a bit misleading since we grouped TP under content blocking.

The new minimum/standard setting will be having TP always-on in private browsing, and users who don't want it will need to opt out per-site by adding exceptions in the control center.

Comment 1

5 months ago
(In reply to Johann Hofmann [:johannh] from comment #0)
> The new minimum/standard setting will be having TP always-on in private
> browsing, and users who don't want it will need to opt out per-site by
> adding exceptions in the control center.

Do we need some copy for this?  Or are we just removing the row with the icon and the toggle and leaving it at that?
(Assignee)

Updated

5 months ago
Blocks: 1502374
(Assignee)

Comment 2

5 months ago
(In reply to :Ehsan Akhgari from comment #1)
> (In reply to Johann Hofmann [:johannh] from comment #0)
> > The new minimum/standard setting will be having TP always-on in private
> > browsing, and users who don't want it will need to opt out per-site by
> > adding exceptions in the control center.
> 
> Do we need some copy for this?  Or are we just removing the row with the
> icon and the toggle and leaving it at that?

We should probably ask Bryan and Betsy what they had in mind for about:privatebrowsing. The AS team is currently working on a private search option for that page so the design might change significantly anyway.

I also filed bug 1502374 to ensure that we offer users a way to restore their settings to default when they flipped the toggle to false in the past.
Flags: needinfo?(bbell)

Comment 3

5 months ago
Note: this line was added for the sake of about:privatebrowsing, and we may be able to remove it when this bug is fixed: https://searchfox.org/mozilla-central/rev/5b3b6b8fd9f90087f618c20382e631451136ed2b/toolkit/modules/AsyncPrefs.jsm#23

Updated

5 months ago
Blocks: 1501978

Comment 4

5 months ago
(In reply to :Ehsan Akhgari from comment #3)
> Note: this line was added for the sake of about:privatebrowsing, and we may
> be able to remove it when this bug is fixed:
> https://searchfox.org/mozilla-central/rev/
> 5b3b6b8fd9f90087f618c20382e631451136ed2b/toolkit/modules/AsyncPrefs.jsm#23

Also https://searchfox.org/mozilla-central/rev/5b3b6b8fd9f90087f618c20382e631451136ed2b/toolkit/components/remotepagemanager/MessagePort.jsm#29
(Assignee)

Updated

5 months ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P2 → P1
(Assignee)

Comment 5

5 months ago
This simply removes the content blocking section when TP is not enabled to avoid overpromising.
We may update this UI to alert the user that TP is off after the UX team comes back with a new design.
(Assignee)

Comment 7

5 months ago
Yup, thanks, had a small test failure on try, unfortunately. Will re-land now...
Flags: needinfo?(jhofmann)

Comment 8

5 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd9666a8a5b
Remove Content Blocking toggle from about:privatebrowsing. r=Ehsan

Comment 9

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8bd9666a8a5b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65

Comment 10

5 months ago
I verified this issue on Nightly 65.0a1 (2018-11-07).
Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
You need to log in before you can comment on or make changes to this bug.