1502440 - Add a pref to hide preload/closed tab artifacts on DevEdition/Beta/Release

Status: VERIFIED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

As there is nothing to do for users, we should hide "Recently closed tabs" and "Preload: New tab". Those entries reflect internal workings only interesting for very technical users.

They should be OK to show by default on DevEdition & Nightly.

Related, bug 1502420 will hide the moz-nullprincipal.

Comment 1

[:Harald Kirschner :digitarald]

Florian and I just talked that this should also hide the Firefox window entry (labeled "Nightly") and sub-items.

They might come back in different shape when we can split the work on separate window instances.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72255ba565a3
Hide browser internals in about:performance for beta and release users, r=felipe.

Comment 4

[Florian Quèze [:florian]]

This is one of the patches we'll want to uplift to 64 to reduce user confusion.

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/72255ba565a3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 9021531 [details] [diff] [review]
Patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: new-about-performance-m1

User impact if declined: Users may be confused by unactionable elements listed in about:performance.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: QE is already working on verifying this feature more generally than just this bug. The step that matters here will be to test after setting the toolkit.aboutPerformance.showInternals pref to false when testing on Nightly.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Straightforward patch.

String changes made/needed: none

Comment 8

[Gyula Palko[:gpalko]]

Verified on Nightly 65(20181105220107), that system addons, preload/closed tabs and "Nightly" are not shown on about:performance page, if toolkit.aboutPerformance.showInternals is set to false.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9021531 [details] [diff] [review]
Patch

about:performance tweak, approved for 64.0b8

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/61362de96df9

Comment 11

[Gyula Palko[:gpalko]]

Verified on Beta 64b8(20181108141956), that system addons, preload/closed tabs and "Firefox" are not shown on about:performance page, toolkit.aboutPerformance.showInternals is set to false by default.