1502483 - raptor-test should test for presence of Git and emit an error message if it's not found

Status: RESOLVED FIXED

(Testing :: Raptor, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) Install mozilla-build on 2018 Quantum Reference device
2) Run ./mach bootstrap to set up the infrastructure for a Firefox Desktop artifact build
3) Run ./mach build to build an artifact build
4) Run ./mach raptor-test --test raptor-tp6 to run the raptor-tp6 suite

ER:

Should run the raptor-tp6 suite

AR:

Here's what I got in the console:

$ ./mach raptor-test --test raptor-tp6
Updating external benchmarks from https://github.com/mozilla/perf-automation
[Error 2] The system cannot find the file specified

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Gijs, apparently you got some Raptor tests running on the 2018 device... any insight here?

Comment 2

[Robert Wood [:rwood]]

Hey Mike, probably a silly question but is git available in your path in the terminal you're running Raptor from?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Robert Wood [:rwood] from comment #2)
> Hey Mike, probably a silly question but is git available in your path in the
> terminal you're running Raptor from?

Not a silly question at all - no it is not. I guess we don't distribute it with mozilla-build? Should I install it?

Comment 4

[Robert Wood [:rwood]]

Ah, yes Raptor uses git to checkout a specific rev of the benchmark source (to a local .mozbuild/performance-tests repo), so yep you'll need to install it and have it in the path.

Thanks for filing this bug - we need to have raptor test for Git and dump out a message indicating it cannot run if Git is not available.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Gotcha, thanks!

Comment 6

[Robert Wood [:rwood]]

:bebe, would you have a chance to pick this one up? Should be a fairly quick one.

Comment 8

[:Gijs (he/him)]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #1)
> Gijs, apparently you got some Raptor tests running on the 2018 device... any
> insight here?

Yes, in fact I filed a dupe when I ran into it...

Comment 9

[Robert Wood [:rwood]]

(In reply to :Gijs (he/him) from comment #8)
> (In reply to Mike Conley (:mconley) (:⚙️) from comment #1)
> > Gijs, apparently you got some Raptor tests running on the 2018 device... any
> > insight here?
> 
> Yes, in fact I filed a dupe when I ran into it...

Ah, thanks :Gijs, I see yours was filed against Testing=>General and not Testing=>Raptor so I didn't see it (sorry).

Comment 10

[Florin Strugariu [:Bebe]]

Attachment: Bug 1502483 raptor-test should test for presence of Git and emit an error message if it's not found r? rwood

Comment 11

[Robert Wood [:rwood]]

(In reply to Florin Strugariu [:Bebe] from comment #10)
> Created attachment 9020747 [details]
> Bug 1502483 raptor-test should test for presence of Git and emit an error
> message if it's not found r? rwood

Thanks :Bebe, please provide a try link with Raptor jobs on each platform, thanks!

Comment 12

[Robert Wood [:rwood]]

Pushing to try on :Bebe's behalf as he doesn't have perms yet

Comment 13

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=72383dd197a9590650823066b27d0bca026a958a

Comment 14

[Robert Wood [:rwood]]

Landed:

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b424df899a126d25503c3c818ad6931d785cf3bf

Comment 15

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b424df899a12