Closed Bug 1502488 Opened 11 months ago Closed 11 months ago
Can't play Opus file mapping 2 where channels count is 6 (and other)
46 bytes, text/x-phabricator-request
|Details | Review|
No description provided.
STR: 1- Set user-agent to Chrome 2- Open http://youtu.be/KEXsXsEGQGg Expected: Play What happens: Doesn't play (decoding error) 6 channels opus mapping 2 fail to play (and others)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4a85f19e21f4 Fix opus mapping 2 channels count check. r=padenot
Comment on attachment 9020442 [details] Bug 1502488 - Fix opus mapping 2 channels count check. r?padenot! [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1482605 User impact if declined: Some YT 360 videos won't play. Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: No Needs manual test from QE?: Yes If yes, steps to reproduce: See description List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Gtest String changes made/needed:
Attachment #9020442 - Flags: approval-mozilla-beta?
Comment on attachment 9020442 [details] Bug 1502488 - Fix opus mapping 2 channels count check. r?padenot! [Triage Comment] Fixes playback issues with some YouTube videos. Approved for 64.0b6.
Attachment #9020442 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified - fixed on latest Firefox Nightly 65.0a1 (2018-11-01) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.