Closed Bug 1502488 Opened 6 years ago Closed 6 years ago

Can't play Opus file mapping 2 where channels count is 6 (and other)

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- wontfix
firefox64 --- verified
firefox65 --- verified

People

(Reporter: jya, Assigned: jya)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1502488 - Fix opus mapping 2 channels count check. r?padenot!
46 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review 
      No description provided.
STR:
1- Set user-agent to Chrome
2- Open http://youtu.be/KEXsXsEGQGg

Expected: Play
What happens: Doesn't play (decoding error)

6 channels opus mapping 2 fail to play (and others)
Priority: -- → P2
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a85f19e21f4
Fix opus mapping 2 channels count check. r=padenot
https://hg.mozilla.org/mozilla-central/rev/4a85f19e21f4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9020442 [details]
Bug 1502488 - Fix opus mapping 2 channels count check. r?padenot!

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1482605

User impact if declined: Some YT 360 videos won't play.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: See description

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Gtest

String changes made/needed:
Attachment #9020442 - Flags: approval-mozilla-beta?
status-firefox63: --- → wontfix
status-firefox64: --- → affected
status-firefox-esr60: --- → unaffected
Flags: qe-verify+
Flags: in-testsuite+
Keywords: regression
Comment on attachment 9020442 [details]
Bug 1502488 - Fix opus mapping 2 channels count check. r?padenot!

[Triage Comment]
Fixes playback issues with some YouTube videos. Approved for 64.0b6.
Attachment #9020442 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified - fixed on latest Firefox Nightly 65.0a1 (2018-11-01) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.
status-firefox65: fixed → verified
Verified - fixed on latest Firefox Beta 64.0b6 (64-bit)(Biuld ID: 20181101155334) on Windows 10 x 64, Windows 7 x32, Mac OS 10.13 and on Ubuntu 16.04 x64.

Based on Comment 8 and Comment 9, will mark close this issue as Verified - Fixed.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
Flags: qe-verify+
Depends on: 1504944
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: